Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Bug 1124241 - added jit category external program #2834

Merged
merged 2 commits into from
Jun 10, 2015
Merged

Fixes Bug 1124241 - added jit category external program #2834

merged 2 commits into from
Jun 10, 2015

Conversation

twobraids
Copy link
Contributor

I've written this in the form of a classifier rule. This is all it takes to put the stdio results of an external program into a single key in a processed crash. This is a fine example of a classifier that anyone could write to include in Socorro.

Placing the output of this external program into the "classifications.jit" namespace within the processed crash, makes it readily available for access by future rules, such as signature manipulation. At the same time this imposes a hierarchical structure on what will likely evolve into many different types of crash classification systems. Signature itself is just another classifications system that happens to have gotten into Socorro first and so remains entrenched. I encourage others to write classifiers. A new one could, perhaps, end up being far more useful than the current signature system tracing back to 2007.

Once this predicate and form of the invocation are accepted, we can enable it at any time by uncommenting the block in socorro/processor/mozilla_processor_2015.py in this PR.

This PR makes no attempt to ensure the building, loading, provisioning, or verification of the name of the jit-crash-categorize external program. Collaboration on that is welcome.

@luser
Copy link
Contributor

luser commented Jun 9, 2015

#2839 added the jit-crash-categorize code, FYI.

@twobraids
Copy link
Contributor Author

discussion on this topic has been with the consumers of the data in https://bugzilla.mozilla.org/show_bug.cgi?id=1124241

I realize that there isn't a lot of agreement on how to detect the target crashes for the application of this external tool. @rhelmer, I suggest putting the PR on hold/withdraw until Q3 and consensus on the predicate algorithm.

@twobraids twobraids changed the title Stage 1 of Bug 1124241 - added jit category external program Fixes Bug 1124241 - added jit category external program Jun 10, 2015
@rhelmer
Copy link
Contributor

rhelmer commented Jun 10, 2015

r+

rhelmer added a commit that referenced this pull request Jun 10, 2015
Fixes Bug 1124241 - added jit category external program
@rhelmer rhelmer merged commit bc2e3a1 into mozilla-services:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants