bug 1542390: rewrite bugzilla associations crontabber job #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites the bugzilla association crontabber job as a Django command. This also adds some needed features in cronrun--it passes the last_success time now.
willkg
commented
Apr 8, 2019
| @@ -14,7 +14,7 @@ set -eo pipefail | |||
| ./socorro-cmd crontabber --job=archivescraper | |||
|
|
|||
| # Insert data that's no longer on archive.mozilla.org | |||
| ./scripts/insert_missing_versions.py | |||
| python ./scripts/insert_missing_versions.py | |||
willkg
commented
Apr 8, 2019
| start_date = timezone.now() - datetime.timedelta(days=1) | ||
| else: | ||
| # Try to parse it as a datetime | ||
| start_date = parse_datetime(start_date) |
There was a problem hiding this comment.
cronrun passes it in as a datetime.
willkg
commented
Apr 8, 2019
| try: | ||
| cmd_kwargs = {} | ||
| with self.lock_job(job_spec['cmd']): | ||
| with self.lock_job(job_spec['cmd']): |
There was a problem hiding this comment.
I moved the lock_job context outside all the exception handling. If exceptions happen, then the job will unlock.
willkg
commented
Apr 8, 2019
| if job_spec.get('backfill', False): | ||
| # If "backfill" is in the spec, then we want to pass in | ||
| # run_time as an argument | ||
| cmd_kwargs['run_time'] = format_datetime(run_time) |
There was a problem hiding this comment.
These arguments get passed in as strings so the command code can parse them just like any argument.
|
The big difference here is direct sql code vs. using the |
|
self-r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the bugzilla association crontabber job as a Django command.
This also adds some needed features in cronrun--it passes the last_success
time now.