bug 1383113: switch from getattr to getitem notation in breakpad rules #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from getattr notation to getitem notation in the breakpad processor rules. We're transitioning off of DotDict and dict doesn't support getattr notation.
willkg
commented
Apr 27, 2020
| or processed_crash.cpu_arch != "x86" | ||
| processed_crash.get("product", "") != "Firefox" | ||
| or not processed_crash.get("os_name", "").startswith("Windows") | ||
| or processed_crash.get("cpu_arch", "") != "x86" |
There was a problem hiding this comment.
I'll add a note to myself to ask Gabriele and find out if this is still true. It might not be.
willkg
commented
Apr 27, 2020
| ) | ||
| if frames and frames[0].get("module", False): | ||
| # there is a module at the top of the stack, we don't want this | ||
| return False | ||
|
|
||
| signature = processed_crash.get("signature", "") |
There was a problem hiding this comment.
This rule needs to run after mdsw and after signature generation. That should be denoted in the class docstring.
willkg
commented
Apr 27, 2020
| @@ -464,28 +449,34 @@ def test_success_all_types_of_signatures(self, mocked_subprocess_module): | |||
| "Small | js::irregexp::ExecuteCode<T>", | |||
| ] | |||
| for signature in signatures: | |||
| processed_crash = DotDict(base_processed_crash) | |||
| processed_crash.signature = signature | |||
| processed_crash = copy.copy(base_processed_crash) | |||
There was a problem hiding this comment.
All these copies need to be deepcopies because the rules are changing the processed crash in deep and existentially meaningful ways.
The processed crash is deep and wonderful and doing a shallow copy means that tests may not be testing what they think they're testing.
|
self-r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from getattr notation to getitem notation in the breakpad processor rules. We're transitioning off of DotDict and dict doesn't support getattr notation.
I did this in a few passes:
breakpad.pyfile and get tests to passDotDictusage in thetest_breakpad.pyfile and get tests to passTo test: