Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1383113: remove DotDict usage in breakpad rules #5357

Merged
merged 1 commit into from Apr 27, 2020
Merged

bug 1383113: remove DotDict usage in breakpad rules #5357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions socorro/processor/rules/breakpad.py
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@
import subprocess
import threading

from configman.dotdict import DotDict
import glom
import markus

Expand Down Expand Up @@ -165,17 +164,17 @@ def _execute_external_process(
self.logger.warning(msg + " (%s)" % crash_id)
output = {}

stackwalker_data = DotDict()
stackwalker_data.json_dump = output
stackwalker_data.mdsw_return_code = return_code

stackwalker_data.mdsw_status_string = output.get("status", "unknown error")
stackwalker_data.success = stackwalker_data.mdsw_status_string == "OK"
stackwalker_data = {
"json_dump": output,
"mdsw_return_code": return_code,
"mdsw_status_string": output.get("status", "unknown error"),
"success": output.get("status", "") == "OK",
}

self.metrics.incr(
"run",
tags=[
"outcome:%s" % ("success" if stackwalker_data.success else "fail"),
"outcome:%s" % ("success" if stackwalker_data["success"] else "fail"),
"exitcode:%s" % return_code,
],
)
Expand All @@ -185,10 +184,10 @@ def _execute_external_process(
processor_meta["processor_notes"].append(msg)
self.logger.warning(msg + " (%s)" % crash_id)

elif return_code != 0 or not stackwalker_data.success:
elif return_code != 0 or not stackwalker_data["success"]:
msg = "MDSW failed with %s: %s" % (
return_code,
stackwalker_data.mdsw_status_string,
stackwalker_data["mdsw_status_string"],
)
# subprocess.Popen with shell=False returns negative exit codes
# where the number is the signal that got kicked up
Expand Down