bug 1749561: fix supersearch form and refining search #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I hard-coded the simple search fields values in the search_results.html template. This fixes that to use the setting values.
This fixes the javascript parts of the supersearch form when you go to refine the search. It correctly removes the "exists" filters if they exist for the field. It no longer messes up adding a filter for mac_crash_info or other fields where the values get coerced into other things. It still adds filters for product, product_type, platform, and version rather than adding those to the simple form. I thought about trying to figure that out and then decided it's not _critical_, so I'd leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the javascript parts of the supersearch form when you go to refine the search.
It correctly removes the "exists" filters if they exist for the field. It no longer messes up adding a filter for mac_crash_info or other fields where the values get coerced into other things.
It still adds filters for product, product_type, platform, and version rather than adding those to the simple form. I thought about trying to figure that out and then decided it's not critical, so I'd leave it.