bug 1894925: change blocking timeout to 5 #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds handling for TimeoutError so it'll go through the loop again. It increases the blocking timeout to 2 which is slightly longer than 1s. It also changes everything to f-strings. The theory is that in CI, it's taking longer than 1s for localstack to respond sometimes which causes CI to fail and because the loop didn't handle TimeoutError, it would die immediately.
willkg
force-pushed
the
willkg-bug-1894925-waitfor
branch
from
935ff40
to
34d197c
Compare
relud
approved these changes
May 7, 2024
|
Thank you! This passed two CI attempts, so I think it probably helps. Maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the blocking timeout to 5s for waitfor--previously it used the socket default timeout of 1s.
The theory is that in CI, it's taking longer than 1s for localstack to respond sometimes which causes CI to fail.