bug 1889156: script to load processed crashes into Elasticsearch #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancadanforth
force-pushed
the
bug-1889156
branch
3 times, most recently
from
ecddb5a
to
ed713a7
Compare
willkg
reviewed
May 8, 2024
biancadanforth
force-pushed
the
bug-1889156
branch
12 times, most recently
from
7720a12
to
cbe3687
Compare
biancadanforth
commented
May 20, 2024
Comment on lines
195
to
199
| except Exception as exc: | ||
| click.echo( | ||
| f"Unable to load crash with ID {crash_id!r} from {type(crash_source).__name__!r}; error: {exc}." | ||
| ) | ||
| continue |
There was a problem hiding this comment.
I couldn't think of any special types of exceptions that we'd want to handle differently -- are there any?
Also, please let me know if we'd like to handle exceptions in the general case differently -- right now we just log to stdout that we couldn't load it and move on.
relud
reviewed
May 20, 2024
relud
reviewed
May 20, 2024
biancadanforth
force-pushed
the
bug-1889156
branch
from
c8132d0
to
9704c8f
Compare
|
Okay I've updated the PR for all your feedback except for #6609 (comment) . I'll submit a separate commit for that tomorrow, so it's easier to revert if willkg weighs in and says it's a bad idea. |
biancadanforth
added a commit
that referenced
this pull request
May 22, 2024
biancadanforth
force-pushed
the
bug-1889156
branch
from
e9ec174
to
85284aa
Compare
biancadanforth
commented
May 22, 2024
relud
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This PR:
settings.CRASH_SOURCE) into Elasticsearch by either date (YYYY-MM-DD) or crash ID.How to test this locally
I have painstakingly added test cases for all the major scenarios, so running the tests in
socorro/tests/test_load_processed_crashes_into_es.py(or replicating the setup before running the script with similar args) should be sufficient.The test cases conditionally skip based onSee #6609 (comment) -- this PR now runs both test cases against both cloud providers thanks to some clever pytest config.settings.CLOUD_PROVIDER, so to test the script with GCS as the crash storage source locally, you can edit yourmy.envso thatCLOUD_PROVIDER=GCPand rebuild the test container (which in my case is thedevcontainer). Just don't forget to revert that change when you're done.I can add some manual testing instructions if things aren't clear from the test. I might just add those here tomorrow.