feat: Add Dockerfile support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python can get a bit finicky with configurations and requirements. Adding a Dockerfile to allow for a potentially consistent environment which can run the load tests. See `Dockerfile` for hints on how to run and use the image. Closes #33
pjenvey
approved these changes
Jan 30, 2021
| RUN_DEPS="wget libssl-dev" && \ | ||
| apt-get update && \ | ||
| apt-get install -yq --no-install-recommends ${BUILD_DEPS} ${RUN_DEPS} && \ | ||
| pip install virtualenv && \ |
There was a problem hiding this comment.
Could drop the venv entirely since it's all self hosted in docker
|
I was debating that, but my reasoning was around that the RUN steps might
be extracted and run by QA on a stand alone instance.
…On Fri, Jan 29, 2021, 4:12 PM Philip Jenvey ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In Dockerfile
<#34 (comment)>
:
> +RUN mkdir -p /app
+ADD . /app
+WORKDIR /app
+
+# Building:
+# you can build a local docker image using
+# `docker build . --tag syncstorage-loadtest:local`
+
+# system setup
+RUN \
+ BUILD_DEPS="git build-essential" && \
+ # wget not required but nice to have
+ RUN_DEPS="wget libssl-dev" && \
+ apt-get update && \
+ apt-get install -yq --no-install-recommends ${BUILD_DEPS} ${RUN_DEPS} && \
+ pip install virtualenv && \
Could drop the venv entirely since it's all self hosted in docker
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#34 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIXKZNIRXNRGE7CATKBCDS4NFFLANCNFSM4WZHP5EQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python can get a bit finicky with configurations and requirements.
Adding a Dockerfile to allow for a potentially consistent environment
which can run the load tests.
See
Dockerfilefor hints on how to run and use the image.Testing
See
Dockerfilefor hints.This should build a docker image which allows folk to run a load test.
Issue(s)
Closes #33