Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add last_use_time to recycler #1008

Closed
jrconlin opened this issue Feb 26, 2021 · 0 comments · Fixed by #1009
Closed

Add last_use_time to recycler #1008

jrconlin opened this issue Feb 26, 2021 · 0 comments · Fixed by #1009
Assignees
@jrconlin
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
Services Engineering

Comments

@jrconlin
Copy link
Member

There's some debate about if Protobuf updates the Session approximate_last_use_time. It wouldn't hurt to manually update that value when we recycle a connection.
@jrconlin jrconlin added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Feb 26, 2021
@jrconlin jrconlin self-assigned this Feb 26, 2021
@jrconlin jrconlin added this to Backlog: Misc in Services Engineering via automation Feb 26, 2021
jrconlin added a commit that referenced this issue Feb 26, 2021
@jrconlin
feat: Manually update the spanner session approximate_last_used_time
d1705ba 
Closes #1008
@jrconlin jrconlin mentioned this issue Feb 26, 2021
Merged
@jrconlin jrconlin moved this from Backlog: Misc to In Review in Services Engineering Mar 1, 2021
Services Engineering automation moved this from In Review to Done Mar 12, 2021
pjenvey pushed a commit that referenced this issue Mar 12, 2021
@jrconlin
feat: Manually update the spanner session approximate_last_used_time (#…
f669b25 
…1009)

* feat: Manually update the spanner session approximate_last_used_time

Closes #1008
@jrconlin jrconlin moved this from Done to Archived in Services Engineering Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Manually update the spanner session approximate_last_used_time mozilla-services/syncstorage-rs
1 participant
@jrconlin