Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break apart "middleware.rs" #391

Closed
jrconlin opened this issue Jan 2, 2020 · 0 comments · Fixed by #392
Closed

Break apart "middleware.rs" #391

jrconlin opened this issue Jan 2, 2020 · 0 comments · Fixed by #392
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. cleanup
Projects
Services Engineering

Comments

@jrconlin
Copy link
Member

jrconlin commented Jan 2, 2020

middleware.rs is a bit unweildy. We should break it apart into discrete components rather than pile them all into one file.
@jrconlin jrconlin added cleanup 3 Estimate - m - This is a small change, but there's some uncertainty. labels Jan 2, 2020
@jrconlin jrconlin added this to Backlog: Misc in Services Engineering via automation Jan 2, 2020
@tublitzed tublitzed moved this from Backlog: Misc to Backlog: Sync in Services Engineering Jan 2, 2020
jrconlin added a commit that referenced this issue Jan 2, 2020
@jrconlin
feat: break apart middleware.rs
712c737 
Broke `middleware.rs` into sub components that are easier to understand,
compartmentalize, and potentially share with the larger org.

There should be no impact to existing unit or run tests.

Closes #391
@jrconlin jrconlin mentioned this issue Jan 2, 2020
Merged
@tublitzed tublitzed moved this from Backlog: Sync to In Review in Services Engineering Jan 2, 2020
Services Engineering automation moved this from In Review to Done Jan 6, 2020
jrconlin added a commit that referenced this issue Jan 6, 2020
@jrconlin
feat: break apart middleware.rs (#392)
5b0fb64 
Broke `middleware.rs` into sub components that are easier to understand,
compartmentalize, and potentially share with the larger org.

There should be no impact to existing unit or run tests.

Closes #391
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. cleanup
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: break apart middleware.rs mozilla-services/syncstorage-rs
1 participant
@jrconlin