Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit 503 Conflict errors to sentry #614

Closed
pjenvey opened this issue May 1, 2020 · 0 comments · Fixed by #623
Closed

Don't emit 503 Conflict errors to sentry #614

pjenvey opened this issue May 1, 2020 · 0 comments · Fixed by #623
Assignees
@jrconlin
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. cleanup
Projects
Services Engineering

Comments

@pjenvey
Copy link
Member

pjenvey commented May 1, 2020 •
edited

We've been meaning to stop sending these, let's finally stop sending them. No longer reporting them will help w/ the issue outlined in #613.

Let's consider emitting a metric for these instead if it's not too difficult.

lock_for_write can emit these in a different manner than the typical way they're emitted (due to Spanner returning an ABORTED). If we do a metric, we could optionally also track these different types separately (via a metric tag): but this is just a nice to have.
@pjenvey pjenvey added the cleanup label May 1, 2020
@pjenvey pjenvey added this to Backlog: Misc in Services Engineering via automation May 1, 2020
@pjenvey pjenvey added the 3 Estimate - m - This is a small change, but there's some uncertainty. label May 1, 2020
@tublitzed tublitzed moved this from Backlog: Misc to Prioritized in Services Engineering May 1, 2020
@pjenvey pjenvey mentioned this issue May 1, 2020
Open
@tublitzed tublitzed moved this from Prioritized to Scheduled in Services Engineering May 4, 2020
jrconlin added a commit that referenced this issue May 5, 2020
@jrconlin
feat: Don't report Conflict errors to sentry
72356ba 
* Added new metric "db.conflict"
* Added new error method `is_reportable()` for future error filtering.

Closes #614
@jrconlin jrconlin mentioned this issue May 5, 2020
Merged
@tublitzed tublitzed moved this from Scheduled to In Review in Services Engineering May 6, 2020
Services Engineering automation moved this from In Review to Done May 12, 2020
fzzzy added a commit that referenced this issue May 12, 2020
@jrconlin @fzzzy
feat: Don't report Conflict errors to sentry (#623)
b2d9341 
* feat: Don't report Conflict errors to sentry

* Added new metric "db.conflict"
* Added new error method `is_reportable()` for future error filtering.

Closes #614

* f fmt

* f add "6-ALREADY_EXISTS" as a non-reported conflict.

Co-authored-by: Donovan Preston <donovanpreston@gmail.com>
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Jun 1, 2020
@pjenvey pjenvey mentioned this issue Jul 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
3 Estimate - m - This is a small change, but there's some uncertainty. cleanup
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Don't report Conflict errors to sentry mozilla-services/syncstorage-rs
2 participants
@pjenvey @jrconlin