Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate_node.py bso num bug #636

Closed
erkolson opened this issue May 14, 2020 · 1 comment · Fixed by #637
Closed

migrate_node.py bso num bug #636

erkolson opened this issue May 14, 2020 · 1 comment · Fixed by #637
Labels
bug Something isn't working

Comments

@erkolson
Copy link

When --bso_num 0 is passed to the script, all 20 bsos are scanned/uploaded.

This is due to 0 evaluating to False here:
https://github.com/mozilla-services/syncstorage-rs/blob/master/tools/user_migration/migrate_node.py#L779-L780

I don't know that we need to have --start_bso and --end_bso as options anymore (making bso_num required), as in practice we will be splitting BSOs across multiple processes and not using a single process to move multiple BSOs. I'm not sure how it was able to migrated data from other BSOs given that it was only provided with a single bso file!

@tublitzed tublitzed added this to Backlog: Misc in Services Engineering via automation May 14, 2020
@tublitzed tublitzed moved this from Backlog: Misc to Prioritized in Services Engineering May 14, 2020
@tublitzed tublitzed added the bug Something isn't working label May 14, 2020
@erkolson
Copy link
Author

I looked at the migration logs and found that it looped through 0 to 19 and uploaded the same 2 users that were in the provided bso file 20 times.

jrconlin added a commit that referenced this issue May 14, 2020
jrconlin added a commit that referenced this issue May 14, 2020
jrconlin added a commit that referenced this issue May 14, 2020
jrconlin added a commit that referenced this issue May 14, 2020
Services Engineering automation moved this from Prioritized to Done May 14, 2020
pjenvey pushed a commit that referenced this issue May 14, 2020
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants