-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate_node.py bso num bug #636
Labels
bug
Something isn't working
Projects
Comments
I looked at the migration logs and found that it looped through |
jrconlin
added a commit
that referenced
this issue
May 14, 2020
jrconlin
added a commit
that referenced
this issue
May 14, 2020
jrconlin
added a commit
that referenced
this issue
May 14, 2020
jrconlin
added a commit
that referenced
this issue
May 14, 2020
pjenvey
pushed a commit
that referenced
this issue
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
--bso_num 0
is passed to the script, all 20 bsos are scanned/uploaded.This is due to
0
evaluating to False here:https://github.com/mozilla-services/syncstorage-rs/blob/master/tools/user_migration/migrate_node.py#L779-L780
I don't know that we need to have
--start_bso
and--end_bso
as options anymore (making bso_num required), as in practice we will be splitting BSOs across multiple processes and not using a single process to move multiple BSOs. I'm not sure how it was able to migrated data from other BSOs given that it was only provided with a single bso file!The text was updated successfully, but these errors were encountered: