Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: byte index 5 is out of bounds of True #647

Closed
jrconlin opened this issue May 28, 2020 · 0 comments · Fixed by #664
Closed

panic: byte index 5 is out of bounds of True #647

jrconlin opened this issue May 28, 2020 · 0 comments · Fixed by #664
Assignees
@pjenvey
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. good first bug Low priority, but valuable contributions p1 Stuff we gotta do before we ship!

Comments

@jrconlin
Copy link
Member

A completely invalid Auth header was attempted. We should probably do a minimum length check to avoid the panic

https://sentry.prod.mozaws.net/operations/syncstorage-prod/issues/8572736/?environment=release
@jrconlin jrconlin added 1 Estimate - xs - This is a trivial change with clearly defined parameters. good first bug Low priority, but valuable contributions labels May 28, 2020
@pjenvey pjenvey added the p1 Stuff we gotta do before we ship! label May 28, 2020
@pjenvey pjenvey self-assigned this Jun 9, 2020
pjenvey added a commit that referenced this issue Jun 9, 2020
@pjenvey
fix: range check the header to avoid a panic
5661dbe 
Closes #647
@pjenvey pjenvey mentioned this issue Jun 9, 2020
Merged
jrconlin pushed a commit that referenced this issue Jun 10, 2020
@pjenvey
fix: range check the header to avoid a panic (#664)
b73e6ee 
Closes #647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. good first bug Low priority, but valuable contributions p1 Stuff we gotta do before we ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: range check the header to avoid a panic mozilla-services/syncstorage-rs
2 participants
@pjenvey @jrconlin