Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old DB middleware #693

Closed
AzureMarker opened this issue Jun 29, 2020 · 2 comments · Fixed by #1020
Closed

Remove old DB middleware #693

AzureMarker opened this issue Jun 29, 2020 · 2 comments · Fixed by #1020
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. bb8-followup Follow-up issues from the bb8 migration cleanup good first bug Low priority, but valuable contributions p1 Stuff we gotta do before we ship!

Comments

@AzureMarker
Copy link
Contributor

After the bb8 refactor (#692), the DB middleware (src/web/middleware/db.rs) is unused. It should be deleted.
@AzureMarker AzureMarker mentioned this issue Jun 29, 2020
Closed
@fzzzy fzzzy added 1 Estimate - xs - This is a trivial change with clearly defined parameters. good first bug Low priority, but valuable contributions labels Jun 29, 2020
@jrconlin
Copy link
Member

image

@AzureMarker AzureMarker mentioned this issue Jul 2, 2020
Merged
@AzureMarker AzureMarker added the bb8-followup Follow-up issues from the bb8 migration label Jul 16, 2020
@pjenvey pjenvey added cleanup p1 Stuff we gotta do before we ship! labels Oct 5, 2020
@pjenvey
Copy link
Member

pjenvey commented Oct 7, 2020 •
edited

DbMiddleware is the last user of the sentry queue_report, so we should kill it along with the middleware. Basically reverting most if not all of #604 which is not a small chunk of code.

@pjenvey pjenvey mentioned this issue Oct 21, 2020
Closed
pjenvey added a commit that referenced this issue Mar 10, 2021
@pjenvey
chore: kill the long unused db middleware
2b0500b 
and a few more dep updates. also remove the hyper dep which we don't need (it's
a sub-dependency)

Closes #693
Closes #1018
This was referenced Mar 10, 2021
Merged
Closed
pjenvey added a commit that referenced this issue Mar 10, 2021
@pjenvey
chore: kill the long unused db middleware
8f9cce7 
and a few more dep updates. also remove the hyper dep which we don't need (it's
a sub-dependency)

Closes #693
Closes #1018
@ethowitz ethowitz mentioned this issue Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. bb8-followup Follow-up issues from the bb8 migration cleanup good first bug Low priority, but valuable contributions p1 Stuff we gotta do before we ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: kill the long unused db middleware mozilla-services/syncstorage-rs
4 participants
@pjenvey @jrconlin @fzzzy @AzureMarker