Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-section environment configuration options not being read properly #762

Closed
jrconlin opened this issue Aug 5, 2020 · 2 comments · Fixed by #763
Closed

Sub-section environment configuration options not being read properly #762

jrconlin opened this issue Aug 5, 2020 · 2 comments · Fixed by #763
Assignees
@jrconlin
Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug Low priority, but valuable contributions
Projects
Services Engineering

Comments

@jrconlin
Copy link
Member

jrconlin commented Aug 5, 2020 •
edited

From limited local testing:

1) Config wants the prefix to match case, PREFIX should be UPPERCASE
2) The default separator is ".", which can cause some shells to improperly recognize the env var.

(e.g. SYNC_LIMITS.DEBUG_CLIENT=2 cargo run) produces a shell error SYNC_LIMITS.DEBUG_CLIENT=2: command not found

Suggest that double underscore be used as the separator value.
@jrconlin jrconlin added the 2 Estimate - s - This is a small change with clearly defined parameters. label Aug 5, 2020
@jrconlin jrconlin added this to Backlog: Misc in Services Engineering via automation Aug 5, 2020
@jrconlin jrconlin moved this from Backlog: Misc to Backlog: Sync in Services Engineering Aug 5, 2020
@jrconlin jrconlin added the good first bug Low priority, but valuable contributions label Aug 5, 2020
@pjenvey
Copy link
Member

pjenvey commented Aug 5, 2020

Some previous discussion of this here: #320 (comment)

jrconlin added a commit that referenced this issue Aug 5, 2020
@jrconlin
bug: set config env separator to double underscore.
9afb761 
Closes #762
@jrconlin jrconlin mentioned this issue Aug 5, 2020
Merged
jrconlin added a commit that referenced this issue Aug 5, 2020
@jrconlin
bug: set config env separator to double underscore.
76a6bf0 
Closes #762
Issue #320
@jrconlin
Copy link
Member Author

jrconlin commented Aug 5, 2020

Oh, yeah. Forgot about that one. Thanks! I'll amend the PR to reference that issue too.

@tublitzed tublitzed moved this from Backlog: Sync to In Review in Services Engineering Aug 6, 2020
Services Engineering automation moved this from In Review to Done Aug 6, 2020
tublitzed pushed a commit that referenced this issue Aug 6, 2020
@jrconlin
bug: set config env separator to double underscore. (#763)
f1d88fe 
Closes #762
Issue #320
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug Low priority, but valuable contributions
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: set config env separator to double underscore. mozilla-services/syncstorage-rs
2 participants
@pjenvey @jrconlin