Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass along mobile client info to sentry #787

Closed
tublitzed opened this issue Aug 17, 2020 · 1 comment · Fixed by #792
Closed

Pass along mobile client info to sentry #787

tublitzed opened this issue Aug 17, 2020 · 1 comment · Fixed by #792
Assignees
@pjenvey
Labels
bug Something isn't working
Projects
Services Engineering

Comments

@tublitzed
Copy link
Contributor

It looks like somewhere along the way (possible not in this repo, but filing here for now) we're dropping the user agent details for iOS and Android clients before it gets to Sentry.

See here for an error that's from an iOS client (which I know because it was me) and here for Android Nightly (same). We should track down where we're losing the UA data, and make sure it gets passed along to Sentry to help with debugging possible mobile client related issues in the future.
@tublitzed tublitzed added this to Backlog: Misc in Services Engineering via automation Aug 17, 2020
@tublitzed tublitzed moved this from Backlog: Misc to Prioritized in Services Engineering Aug 17, 2020
@tublitzed tublitzed added the bug Something isn't working label Aug 17, 2020
@pjenvey pjenvey mentioned this issue Aug 17, 2020
Open
@pjenvey
Copy link
Member

pjenvey commented Aug 17, 2020

Our sub-optimal UA parsing has been a known issue, I've logged #788 for this.

#788 is a larger effort, I think in the meantime a quick fix here is to log the full UA string as an "extra" (the event will then show it towards the bottom in "Additional Data", alongside uri.path).

pjenvey added a commit that referenced this issue Aug 18, 2020
@pjenvey
feat: emit internal bb8 Pool errors to logs/sentry
ec25bc4 
- add a keepalive setting
- fix: don't urldecode bso_ids from JSON
- pass the user-agent to sentry as an extra

Closes #786
Closes #785
Closes #764
Closes #787
@pjenvey pjenvey self-assigned this Aug 18, 2020
@pjenvey pjenvey moved this from Prioritized to In Progress in Services Engineering Aug 18, 2020
@pjenvey pjenvey mentioned this issue Aug 18, 2020
Merged
Services Engineering automation moved this from In Progress to Done Aug 21, 2020
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
bug Something isn't working
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: emit internal bb8 Pool errors to logs/sentry mozilla-services/syncstorage-rs
2 participants
@pjenvey @tublitzed