Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch spanner's db pool to deadpool #794

Closed
pjenvey opened this issue Aug 20, 2020 · 0 comments · Fixed by #802
Closed

Switch spanner's db pool to deadpool #794

pjenvey opened this issue Aug 20, 2020 · 0 comments · Fixed by #802
Assignees
@pjenvey
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined.
Projects
Services Engineering

Comments

@pjenvey
Copy link
Member

pjenvey commented Aug 20, 2020

There's a few known issues w/ bb8, most notably Drop impl stalls application (bb8#75) & Stuck in Timed out/Conn leaks (bb8#67) (and possibly async mutex (bb8#74) but I don't think it affects us).

These issues are being worked on but let's try out deadpool in the meantime. It's not as configurable as r2d2/bb8 but until 0.5.x stabilizes, less moving parts is a good thing. We can leave the bb8 manager around and revisit it when some of the pending bb8 fixes land.
@pjenvey pjenvey added the 5 Estimate - l - Moderately complex, will require some effort but clearly defined. label Aug 20, 2020
@pjenvey pjenvey added this to Backlog: Misc in Services Engineering via automation Aug 20, 2020
@pjenvey pjenvey self-assigned this Aug 20, 2020
@pjenvey pjenvey moved this from Backlog: Misc to In Progress in Services Engineering Aug 20, 2020
pjenvey added a commit that referenced this issue Aug 21, 2020
@pjenvey
feat: switch spanner's db pool to deadpool
0e5a2c4 
this is a quick integration of deadpool to be revisited with some more
cleanup

Issue #794
pjenvey added a commit that referenced this issue Aug 21, 2020
@pjenvey
feat: switch spanner's db pool to deadpool
077bf09 
this is a quick integration of deadpool to be revisited with some more
cleanup

Issue #794
This was referenced Aug 21, 2020
Merged
Open
pjenvey added a commit that referenced this issue Aug 24, 2020
@pjenvey
feat: cleanup the spanner pool managers
746f5d1 
- ignore deadpool's Status::available negative values for PoolState
- kill no longer used DB_THREAD_POOL_SIZE

Closes #794
@pjenvey pjenvey mentioned this issue Aug 24, 2020
Merged
Services Engineering automation moved this from In Progress to Done Aug 25, 2020
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Aug 31, 2020
@fggarcia fggarcia mentioned this issue Sep 19, 2020
Closed
@fggarcia fggarcia mentioned this issue Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined.
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cleanup the spanner pool managers mozilla-services/syncstorage-rs
1 participant
@pjenvey