don't convert all oauth token verification errors to resource_unavailable #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able we have a `Result<VerifyOutput, BlockingError<TokenserverError>>` here. mapping all BlockingError::Error values to resource_unavailable causes 503 response for expired oauth tokens, which breaks sync from firefox. we previously returned the wrapped error unaltered (only turning a JoinError into resource_unavailable), so go back to that.
ethowitz
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
@pennae Really great catch. This would not affect our production deployment, since we cache FxA's public key there, but it would absolutely affect anybody self-hosting a Sync backend. I dug into why Tokenserver's end-to-end tests didn't catch this, and it's because we only run the e2e tests with a Tokenserver that has a cached JWK. I will open a separate PR to add an additional run of the e2e tests where Tokenserver does not have a cached JWK.
We really appreciate your contribution!
|
yup, that's exactly how we found it. thought our homegrown accounts server had broken an expectation again at first, but some digging eventually led us to here. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we have a
Result<VerifyOutput, BlockingError<TokenserverError>>here. mapping all BlockingError::Error values to resource_unavailable causes 503 response for expired oauth tokens, which breaks sync from firefox. we previously returned the wrapped error unaltered (only turning a JoinError into resource_unavailable), so go back to that.Testing
reliably: use 0.12.1 with an expired or revoked oauth token and observe that sync does not work and does not recover. apply patch and see it recover.
Issue(s)
none.