chore: add minumum supported rust version #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.39 should be good. 1.40 has a bunch of fixes, but I don't believe we're impacted by any of them. Local build --all-targets & tests ran without error under 1.39. |
jrconlin
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help us avoid future issues with folks using the wrong rust version, I'm adding this field into our cargo.toml.
Testing
Well...the main thing to review is: did I get the version right? :) I picked 1.39.0 given that I at least know for sure that we're depending on async/await which was introduced then. Anything that rolled into Rust stable afterwards we're requiring?
Issue(s)
Closes #424.