Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update protobuf to 2.17.0 #783

Merged
merged 2 commits into from Aug 14, 2020
Merged

chore: update protobuf to 2.17.0 #783

merged 2 commits into from Aug 14, 2020

Conversation

jrconlin
Copy link
Member

Closes #782

Description

Updating vendor'd SDK protobuf to 2.17.0

Testing

n/a

Issue(s)

Closes #782

@jrconlin jrconlin requested a review from a team August 13, 2020 22:58
AzureMarker
AzureMarker approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no real changes in any of the generated files, is that expected?

@jrconlin
Copy link
Member Author

Surprisingly, no, not this time. Maybe they're getting better about breaking changes?
(and with that, I have now jinxed 2.17.1)

@jrconlin jrconlin merged commit af5234d into master Aug 14, 2020
@jrconlin jrconlin deleted the chore/782 branch August 14, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureMarker AzureMarker AzureMarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Update vendor to protobuf 2.17
2 participants
@jrconlin @AzureMarker