bug: Return FORBIDDEN if a user's batch is Over Quota #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzzzy
previously approved these changes
Oct 6, 2020
pjenvey
requested changes
Oct 8, 2020
There was a problem hiding this comment.
I was hoping we could take the opportunity to fix #418 here but I'm fine with a quicker fix such as this. This does not fix #418 though, so let's log a "propagate quota errors in batch commit" issue for this PR (I really should have logged it for my comment describing the issue ) and fixup the commit message to point to it
|
updated commit to reflect that this is an "issue" resolution to #418 rather than "closes" |
pjenvey
approved these changes
Oct 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #418
Description
If a user is over quota during a batch operation, the server would return OK with a list of
failedids. The client would retry them, leading to potentially a lot of useless network traffic.Testing
Enable the QUOTA system.
Create a batch that contains more data than should be allowed by the QUOTA.
Confirm that the returned result is a
403 FORBIDDENstatus with the body of14(Note, I used the spanner load test script for this.)
Issue(s)
Issue #418