Merge pull request #76 from mozilla-services/fix-if-none-match-header

Fix If-None-Match header format.

docs/api/resource.rst

@@ -288,7 +288,7 @@ only endpoint that you can use either to create new record or to
 update them.
 
 If you want to make sure that you don't erase an existing record when
-creating one, you can use the ``If-None-Match: "*"`` header value.
+creating one, you can use the ``If-None-Match: *`` header value.
 
 The PUT response body is a JSON mapping containing:
 

syncto/headers.py

@@ -18,7 +18,6 @@ def import_headers(syncto_request, sync_request_headers=None):
     headers['User-Agent'] = ua
 
     # Handle concurrency control.
-
     if 'If-Match' in request_headers:
         if_match = request_headers['If-Match']
         try:
@@ -36,7 +35,7 @@ def import_headers(syncto_request, sync_request_headers=None):
 
     if 'If-None-Match' in request_headers:
         if_none_match = request_headers['If-None-Match']
-        if if_none_match == '"*"':
+        if if_none_match == '*':
             headers['X-If-Unmodified-Since'] = 0
         else:
             try:

syncto/tests/test_functional.py

@@ -424,7 +424,7 @@ def test_can_put_valid_record(self):
 
     def test_put_record_handles_if_none_match_headers(self):
         headers = self.headers.copy()
-        headers['If-None-Match'] = '"*"'
+        headers['If-None-Match'] = '*'
 
         self.app.put_json(RECORD_URL, RECORD_EXAMPLE,
                           headers=headers, status=200)