Total-Records should give the total number of records.

[Natim]

Today Total-Record only contains the number of records in the current request.
Kinto protocol defines it to be the total number of records for the collection.

We should use the syncclient.info_collection() methods in order to return the right number of records. We may want to cache this value when used with pagination.

[Natim]

The right endpoint is get_collection_counts rather than info_collection but that's the same idea.

[Natim]

@rfk is it something that we should fix in syncserver instead?

[Natim]

Actually the documentation describes the implemented feature:

This header may be sent back with multi-record responses, to indicate the total number of records included in the response.

So I guess it is not a Sync Server bug.

[Natim]

@michielbdejong Can I remove this feature from syncto until we actually get a use case?
The scope of Syncto is to let us use Kinto.js to query Sync and Kinto.js doesn't use the Total-Records header.

[Natim]

Here is a proposal to remove Total-Records when paginating and leave it when requesting all records.

r? @leplatrem @michielbdejong

[michielbdejong]

+1 but if next year Kinto.js starts relying on this header, we should somehow remember that Syncto does not implement the entire Kinto API. We will have integration tests that would start failing, but maybe we should also update "using the Kinto API" on http://syncto.readthedocs.org/en/latest/ to "using a subset of the Kinto API", so that this is clear.

[Natim]

Good point thanks.

[Natim]

@leplatrem I have created #51 to track a potential follow up on this.

[coveralls]

Coverage remained the same at 100.0% when pulling f0d9de2 on do-not-support-total-records-with-pagination into 46f4d77 on master.