Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1696585: switch to honcho for eliot #2319

Merged
merged 1 commit into from Mar 15, 2021
Merged

bug 1696585: switch to honcho for eliot #2319

merged 1 commit into from Mar 15, 2021

Conversation

willkg
Copy link
Collaborator

@willkg willkg commented Mar 15, 2021

This switches Eliot to use honcho for process management. We're going to
standardize on honcho for cases where we need to run multiple processes
in the Docker container.

This switches Eliot to use honcho for process management. We're going to
standardize on honcho for cases where we need to run multiple processes
in the Docker container.
@willkg
Copy link
Collaborator Author

willkg commented Mar 15, 2021

After this lands and deploys to stage, we should check the logs to make sure logging is still working.

To test:

  1. run docker-compose up eliot to run eliot

In the output, it'll print this:

eliot_1         | /usr/local/lib/python3.9/subprocess.py:941: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
eliot_1         |   self.stdout = io.open(c2pread, 'rb', bufsize)
eliot_1         | /usr/local/lib/python3.9/subprocess.py:941: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
eliot_1         |   self.stdout = io.open(c2pread, 'rb', bufsize)

That's covered in this Honcho issue: nickstenning/honcho#221

That's fixed, but not released, yet.

@willkg willkg merged commit ae610f3 into mozilla-services:main Mar 15, 2021
@willkg willkg deleted the 1696585-honcho branch March 15, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant