Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to their latest versions. #16

Merged
merged 3 commits into from Jan 8, 2014
Merged

Conversation

rfk
Copy link
Contributor

@rfk rfk commented Jan 7, 2014

This PR gets me a clean build and test with the latest versions of our various dependencies, modulo two upstream bugs in PyZMQ:

zeromq/pyzmq#462
zeromq/pyzmq#463

Mostly just bumping version numbers, but some key points include:

  • new gevent version should install cleanly without a helper script
  • gevent_zeromq is now deprecated, so we have to do our own monkey-patching on top of zmq.green
  • new WebOb throws an error if header values are unicode strings, so we have to encode some BrowserID assertions into bytestrings
  • pypi mirrors are gone so the Makefile is tweaked accordingly

If we don't get a quick response on the upstream bugs I will look at installing from a fork in the meantime.

@ametaireau r?

minor = sys.version_info[1]
plat = sys.platform

HOST = "http://people.mozilla.com/~ametaireau/eggs/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cool. I hated relying on these.

@almet
Copy link
Contributor

almet commented Jan 7, 2014

Sounds all reasonable to me. + it seems that the upstream changes are getting discusses / merged. Nice.

r+

@jbonacci
Copy link

jbonacci commented Jan 8, 2014

Who gets to merge this?
:-)

@rfk
Copy link
Contributor Author

rfk commented Jan 8, 2014

I'll do it today

rfk added a commit that referenced this pull request Jan 8, 2014
Update dependencies to their latest versions; r=ametaireau
@rfk rfk merged commit 3d8901e into master Jan 8, 2014
@rfk rfk mentioned this pull request Jan 8, 2014
@rfk rfk deleted the rfk/update-deps branch January 8, 2014 04:13
@jbonacci
Copy link

This is probably true enough to stay closed, but I am still having a heck of a time building on all OS/platforms.
Will focus on #12 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants