Skip to content
This repository has been archived by the owner on Feb 2, 2018. It is now read-only.

Triggers the signature if the collection has been modified. #31

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Triggers the signature if the collection has been modified. #31

merged 2 commits into from
Mar 15, 2016

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Mar 14, 2016

magopian
magopian reviewed Mar 15, 2016
View reviewed changes
xml2kinto/synchronize.py
@@ -36,4 +36,10 @@ def push_changes(diff, kinto_client, bucket, collection):
for record in to_create:
batch.create_record(record)

if len(to_create) or len(to_delete):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to check the len, if they're empty, they'll still be seen as falsy

@magopian
Copy link
Contributor

needs rebase, and minor nit-pick

Other than that, r+, thanks!

@Natim
Copy link
Contributor Author

Natim commented Mar 15, 2016

Rebased.

Natim added a commit that referenced this pull request Mar 15, 2016
@Natim
Merge pull request #31 from mozilla-services/trigger-kinto-signer
2f111fb 
Triggers the signature if the collection has been modified.
@Natim Natim merged commit 2f111fb into master Mar 15, 2016
@Natim Natim deleted the trigger-kinto-signer branch March 15, 2016 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Natim @magopian