Fix remaining bytes for doc streams #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar-o
force-pushed
the
documents-remaining-bytes
branch
from
a2ae600
to
adc452b
Compare
autrilla
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I misunderstood how
parser.bufferwas getting replenished, so my previous patch worked fine on files up toinput_raw_buffer_sizein size (512 bytes). Hence my tests all passed... anyway this fixes the issue, and I've added specific tests around it. (Didn't notice this until I was working on a patch to incorporate multidoc support into https://github.com/mozilla/sops)