add license (fixes #109) #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codehag
force-pushed
the
fix-109-add-license
branch
from
b00fb37
to
2bf5203
Compare
|
I think |
codehag
force-pushed
the
fix-109-add-license
branch
2 times, most recently
from
6a4f9e7
to
4271cf0
Compare
jorendorff
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
According to the Licensing Runbook, "Rust crates that Firefox depends on are published under an Apache 2.0 / MIT dual license."
codehag
force-pushed
the
fix-109-add-license
branch
from
4271cf0
to
de4f704
Compare
|
ok, its updated accordingly. I read that section as examples, in the foundational text section of the license handbook they recommend either Apache 2.0 or MPL for new projects, so I got a bit confused on what the best direction was. |
jorendorff
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the suggestion I made in the issue