Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Use Kotlin in the real world #1970

Merged
merged 1 commit into from
May 28, 2018
Merged

Use Kotlin in the real world #1970

merged 1 commit into from
May 28, 2018

Conversation

cnevinc
Copy link
Contributor

@cnevinc cnevinc commented May 22, 2018 •
edited
Loading

ktx only works for API 28+.
So we just use pure Koltin.

@cnevinc cnevinc mentioned this pull request May 22, 2018
Closed
@cnevinc cnevinc force-pushed the nevin/use_kotlin branch 2 times, most recently from b4a030d to 8d2d167 Compare May 25, 2018 03:17
@cnevinc cnevinc requested a review from walkingice May 25, 2018 03:17
@cnevinc cnevinc self-assigned this May 25, 2018
@cnevinc cnevinc requested a review from mxlius May 28, 2018 03:15
mxlius
mxlius approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@mxlius mxlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we can still use ktx:0.3, and upgrade to 1.0 once the P sdk is released and we are targeting it.

@cnevinc cnevinc merged commit 6a208e7 into master May 28, 2018
@cnevinc cnevinc deleted the nevin/use_kotlin branch May 28, 2018 06:00
@cnevinc
Copy link
Contributor Author

cnevinc commented May 28, 2018

Thanks, @mxlius
I'll evaluate and maybe do it in another patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@walkingice walkingice walkingice approved these changes

@mxlius mxlius mxlius approved these changes

Assignees

@cnevinc cnevinc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnevinc @walkingice @mxlius