Conversation
96019bb
to
2615724
Compare
app/src/main/java/org/mozilla/focus/telemetry/TelemetryWrapper.kt
Outdated
Show resolved
Hide resolved
c603e1c
to
3367d38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Please consider adding a note to your telemetry documentation stating that your product also uses Glean for sending telemetry and link to the data review response. You can also link to the pings glean sends out of the box for user documentation, here: https://mozilla.github.io/glean/book/user/pings/index.html
@Dexterp37 Thank you for the review! |
We discussed this over Slack, but to recap:
@cnevinc is investigating other options to reduce the impact. If not successful, we'll try to explore ways on our end to attempt reducing the size. |
5960675
to
dfda45d
Compare
Even if we replace the legacy Telemetry library with Glean, we'll still 2MB over our budget. I first think we can use Dynamic Feature. Proposal 2: I can't think of a better way right now. |
looked at the code @Dexterp37 wrote in his PR using [multiple APKS] We will not use multiple APKs, but I think per my discovery in above step, our APK size should not be affected. I'd like to put this PR to Play Store and see the displayed APK size. Or I can build an internal release and see how it looks. |
I've tested the current build and deploy to Play Store with my personal account [see].
The first approach can help us track size growth more precisely. Since we exclude the size of the Glean library. But the number is not the real number on Play Store. The second approach is to
But since we have multiple target ABI, breaking one AIB's size limit won't necessarily break others. Thus make the APK size tracking hard. |
Notes:
The APK size impact is 600~700KB (with AAB and enabling ABI split). After confirming with @shsu571, this PR is ready for review.
I'll add the extra 2861397 bytes that Glean SDK took when checking the APK size.
Glean will only be enabled in debug, firebase, and nightly builds.