Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Allow users to turn off Firebase sharing in Settings #1411

Closed
joechengla opened this issue Feb 9, 2018 · 5 comments
Closed

Allow users to turn off Firebase sharing in Settings #1411

joechengla opened this issue Feb 9, 2018 · 5 comments
Assignees
@cnevinc
Labels
feature need crossfunctional dependency outside EM team need ux/vd UX's or VD's inputs are needed P0 you'd rather block the release for this
Milestone
2.1

Comments

@joechengla
Copy link

Let’s tie Firebase setting to Send Usage Data setting (global switch)
@joechengla joechengla added this to the sprint1.0.5 milestone Feb 12, 2018
@chianger chianger added the 2.0 label Mar 1, 2018
@chianger chianger modified the milestones: sprint1.0.5, 2.0 FeatureComplete Mar 1, 2018
@joechengla joechengla removed the 2.0 label Mar 12, 2018
@joechengla joechengla modified the milestones: 2.0 FeatureComplete, 2.1 Mar 12, 2018
@weslyhuang
Copy link

next step on UX for a design proposal.

@Jacklin-ux Jacklin-ux added the need ux/vd UX's or VD's inputs are needed label Apr 16, 2018
@cnevinc
Copy link
Contributor

cnevinc commented Apr 17, 2018

I'll need the UI design so I know where to add the setting.

@cnevinc
Copy link
Contributor

cnevinc commented Apr 18, 2018

Disable Analytics
https://firebase.google.com/support/guides/disable-analytics
Disable Crashlytics (need to restart the app)
https://firebase.google.com/docs/crashlytics/customize-crash-reports#enable_opt_in_reporting
Disable the performance monitoring ( Not implemented yet)
https://firebase.google.com/docs/perf-mon/disable-sdk

[1] https://firebase.google.com/docs/reference/android/com/google/firebase/iid/FirebaseInstanceId.html#deleteInstanceId()

@weslyhuang
Copy link

Need UX/Product detail. (Risky for May 12?)

  1. new string
  2. may need SUMO for it too.

@weslyhuang weslyhuang added Need Strings need crossfunctional dependency outside EM team labels Apr 18, 2018
cnevinc added a commit that referenced this issue Apr 19, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings. WIP
050c19a
cnevinc added a commit that referenced this issue Apr 19, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings. WIP
62af697
cnevinc added a commit that referenced this issue Apr 20, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings. WIP
8c97e22
cnevinc added a commit that referenced this issue Apr 20, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings. WIP
fb438c0
cnevinc added a commit that referenced this issue Apr 23, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings.
b238dfb
cnevinc added a commit that referenced this issue Apr 25, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings.
c38b26e
@cnevinc cnevinc mentioned this issue Apr 26, 2018
Closed
cnevinc added a commit that referenced this issue Apr 27, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings.
bdb8c5f
cnevinc added a commit that referenced this issue May 3, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase sharing in Settings.
49c9d4a
cnevinc added a commit that referenced this issue May 3, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
215119b
cnevinc added a commit that referenced this issue May 4, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
83db295
cnevinc added a commit that referenced this issue May 4, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
355bc4d
cnevinc added a commit that referenced this issue May 4, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
efeca57
@cnevinc cnevinc mentioned this issue May 4, 2018
Closed
cnevinc pushed a commit that referenced this issue May 10, 2018
Closes #1411: Check for system environment variables for firebase bui…
6fb379c 
…ld type
cnevinc pushed a commit that referenced this issue May 10, 2018
Closes #1411: Fix per comments
fde941c
cnevinc pushed a commit that referenced this issue May 10, 2018
Closes #1411: Fix per comments
75adcf8
cnevinc pushed a commit that referenced this issue May 10, 2018
Closes #1411: Fix per comments
d8bdd07
cnevinc pushed a commit that referenced this issue May 11, 2018
Closes #1411: Fix per comments
0075ff2
cnevinc pushed a commit that referenced this issue May 11, 2018
Closes #1411: Fix per comments
a882c67 
1. Use states from UI in FirebaseHelper.bind()
2. Check for system env at build time
3. Add debug mode for firebase build
4. Make Espresso Tests runs on Firebase build
cnevinc added a commit that referenced this issue May 11, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
eac544b 
In this commit:
1. Move FirebaseHelper.init to a content provider so it gets init earlier.
2. Disable the content provider that Fabric and Firebase previously use.
3. Use Firebasehelper.bind() to flip the switch.
4. Remove gms plugin so no need to verify play-service.json.
5. Manually add the api key to resValue and generates at compile time
6. App module can fail back to firebase or firebase_no_op build type in fireabse module to inject the impl.
7. Add firebase build type to app module, so only people who interested
in Firebase need to use that build type.
8. Make resValue accept environment variables.

TODO:
1. Add the link build.gralde for firebase module, to denote the document
for manually create build id.
2. Add more document to let others know how Fabric and Firebase are
initialized and how to adjust it.
3. let firebase crashlytics accept debug mode

Tests:
I've tested below scnearios:
1. switch on/off Firebase, test RateApp Dialog. It should display
   default value when Firebase is off.
2. make a crash, see if the crash apears in the backend ( may need to
  have debug mode first)
3. switch on/off and test push notification : when app in the
  background / in the foreground / not running (6 test cases)
4. in firebase console, see debug view and check for events.
cnevinc pushed a commit that referenced this issue May 11, 2018
Closes #1411: Check for system environment variables for firebase bui…
c331b66 
…ld type
cnevinc pushed a commit that referenced this issue May 11, 2018
Closes #1411: Fix per comments
a404101 
1. Use states from UI in FirebaseHelper.bind()
2. Check for system env at build time
3. Add debug mode for firebase build
4. Make Espresso Tests runs on Firebase buil
5. Expose FCM token for QA in Nightly and FirebaseDebug build
cnevinc pushed a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Fix for comments
c1a0150
cnevinc pushed a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Make Espresso runs on firebase buildtype
1c1bc21
cnevinc added a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
0f1962e 
In this commit:
1. Move FirebaseHelper.init to a content provider so it gets init earlier.
2. Disable the content provider that Fabric and Firebase previously use.
3. Use Firebasehelper.bind() to flip the switch.
4. Remove gms plugin so no need to verify play-service.json.
5. Manually add the api key to resValue and generates at compile time
6. App module can fail back to firebase or firebase_no_op build type in fireabse module to inject the impl.
7. Add firebase build type to app module, so only people who interested
in Firebase need to use that build type.
8. Make resValue accept environment variables.

TODO:
1. Add the link build.gralde for firebase module, to denote the document
for manually create build id.
2. Add more document to let others know how Fabric and Firebase are
initialized and how to adjust it.
3. let firebase crashlytics accept debug mode

Tests:
I've tested below scnearios:
1. switch on/off Firebase, test RateApp Dialog. It should display
   default value when Firebase is off.
2. make a crash, see if the crash apears in the backend ( may need to
  have debug mode first)
3. switch on/off and test push notification : when app in the
  background / in the foreground / not running (6 test cases)
4. in firebase console, see debug view and check for events.
cnevinc pushed a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Check for system environment variables for firebase bui…
c250c98 
…ld type
cnevinc pushed a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Fix per comments
e28bfb6 
1. Use states from UI in FirebaseHelper.bind()
2. Check for system env at build time
3. Add debug mode for firebase build
4. Make Espresso Tests runs on Firebase buil
5. Expose FCM token for QA in Nightly and FirebaseDebug build
cnevinc pushed a commit that referenced this issue May 13, 2018
@cnevinc
Closes #1411: Make Espresso runs on firebase buildtype
c658655
cnevinc pushed a commit that referenced this issue May 14, 2018
@cnevinc
Closes #1411: Make Espresso runs on firebase buildtype
cab36d4
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Fix per comments
5ed54d0 
1. Use states from UI in FirebaseHelper.bind()
2. Check for system env at build time
3. Add debug mode for firebase build
4. Make Espresso Tests runs on Firebase buil
5. Expose FCM token for QA in Nightly and FirebaseDebug build
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Make Espresso runs on firebase buildtype
846c65e
cnevinc added a commit that referenced this issue May 14, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
d3e404c 
In this commit:
1. Move FirebaseHelper.init to a content provider so it gets init earlier.
2. Disable the content provider that Fabric and Firebase previously use.
3. Use Firebasehelper.bind() to flip the switch.
4. Remove gms plugin and generate google_app_id at compile time. Put
those values in system environment variables.
5. Remove fabric plugin and generate build_id at compile time
6. App module can fall back to 'firebase' or 'firebase_no_op'build type in fireabse module to switch the impl
7. Add 'firebase' build type to app module, so only people who interested
in Firebase need to use that build type.

Tested below scenarios when Firebase is on or off:
1. RemoteConfig: RateApp Dialog should display the correct value
2. Crashlytics: Force a crash, and see if the crash apears in Crashlytics backend (
In debug build)
3. FCM: When the app is in the background/foreground , or not running
4. Anaylytics: In firebase console, see debug view and check for events.
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Let QA test FCM on Nightly
ab510bb
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Make Espresso runs on firebase buildtype
56731f0
cnevinc added a commit that referenced this issue May 14, 2018
@cnevinc
Closes #1411: Allow users to turn off Firebase in Setting.
7287215 
In this commit:
1. Move FirebaseHelper.init to a content provider so it gets init earlier.
2. Disable the content provider that Fabric and Firebase previously use.
3. Use Firebasehelper.bind() to flip the switch.
4. Remove gms plugin and generate google_app_id at compile time. Put
those values in system environment variables.
5. Remove fabric plugin and generate build_id at compile time
6. App module can fall back to 'firebase' or 'firebase_no_op'build type in fireabse module to switch the impl
7. Add 'firebase' build type to app module, so only people who interested
in Firebase need to use that build type.

Tested below scenarios when Firebase is on or off:
1. RemoteConfig: RateApp Dialog should display the correct value
2. Crashlytics: Force a crash, and see if the crash apears in Crashlytics backend (
In debug build)
3. FCM: When the app is in the background/foreground , or not running
4. Anaylytics: In firebase console, see debug view and check for events.
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Let QA test FCM on Nightly
9f7a352
cnevinc pushed a commit that referenced this issue May 14, 2018
Closes #1411: Make Espresso runs on firebase buildtype
3a688a8
cnevinc pushed a commit that referenced this issue May 15, 2018
@cnevinc
Closes #1411: Let QA test FCM on Nightly
90fadf3
cnevinc pushed a commit that referenced this issue May 15, 2018
@cnevinc
Closes #1411: Make Espresso runs on firebase buildtype
c31c47a
mxlius pushed a commit to mxlius/FirefoxLite that referenced this issue Jun 25, 2018
@cnevinc @mxlius
Closes mozilla-mobile#1411: Allow users to turn off Firebase in Setting.
f45ba45 
In this commit:
1. Move FirebaseHelper.init to a content provider so it gets init earlier.
2. Disable the content provider that Fabric and Firebase previously use.
3. Use Firebasehelper.bind() to flip the switch.
4. Remove gms plugin and generate google_app_id at compile time. Put
those values in system environment variables.
5. Remove fabric plugin and generate build_id at compile time
6. App module can fall back to 'firebase' or 'firebase_no_op'build type in fireabse module to switch the impl
7. Add 'firebase' build type to app module, so only people who interested
in Firebase need to use that build type.

Tested below scenarios when Firebase is on or off:
1. RemoteConfig: RateApp Dialog should display the correct value
2. Crashlytics: Force a crash, and see if the crash apears in Crashlytics backend (
In debug build)
3. FCM: When the app is in the background/foreground , or not running
4. Anaylytics: In firebase console, see debug view and check for events.
mxlius pushed a commit to mxlius/FirefoxLite that referenced this issue Jun 25, 2018
@mxlius
Closes mozilla-mobile#1411: Let QA test FCM on Nightly
d0da175
mxlius pushed a commit to mxlius/FirefoxLite that referenced this issue Jun 25, 2018
@mxlius
Closes mozilla-mobile#1411: Make Espresso runs on firebase buildtype
253c7ba
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cnevinc cnevinc

Labels
feature need crossfunctional dependency outside EM team need ux/vd UX's or VD's inputs are needed P0 you'd rather block the release for this
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
5 participants
@cnevinc @joechengla @chianger @weslyhuang @Jacklin-ux