Fringe Page

[mmmavis]

This will fix #178.

I will squash the commits after I get a r+

@Pomax
Not sure what the best way is to review this PR -- I could share the underlying testing Google Form and Spreadsheet with you, as well as my .env file that contains the meta of the testing Google Form. Let me know!

I'm also getting this Warning: owner-based and parent-based contexts differ React warning (from react-formation) that I'm not able to solve. Hopefully you can lend a hand 😁

[mmmavis]

removing this since we are not using hatchet in the code anymore

@ScottDowne and I hold different opinions on whether or not to leave this line in package.json... and neither of us knew what the best practice is. 😛 @Pomax thoughts?

His view:

I think it's just about expectations of what package.json is used for being consistent
If in a year time I was tasked with sending an email from mozfest site, I wouldn't have expected to see a package missing, I would expect to go to .env for that sort of config
but, it's technically not going to break anything, so it's just a matter of expectations and best practice

My preference is to keep the codebase up-to-date -- remove code and modules that aren't being used anymore. If for any reason we want to get "old" code back we use commit history and GitHub tickets to recall our lost memory. And I also think in a year time we are probably gonna switch to use another module (vs hatchet) 🐹

[ScottDowne]

I misunderstood, I didn't know the code that used hatchet was already gone.

I thought it was code we were not using at the moment, but still existed in the repo, as in a send-email endpoint that we were just not hitting anymore, but would be again next year. Taking a closer look, hatchet isn't even used in the repo. Totally remove it if that's the case.

[mmmavis]

yay problem solved! apologies if I didn't explain it clearly in the first place 😜

[mmmavis]

went through this with @Pomax yesterday. merging it noooow