This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
made Xfail for bug 920700 #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,7 +144,7 @@ def test_that_searching_for_cool_returns_results_with_cool_in_their_name_descrip | |||
| search_range = details_page.description + devs_comments | |||
| Assert.contains(search_term, search_range.lower()) | |||
| details_page.return_to_previous_page() | |||
|
|
|||
| @pytest.mark.xfail(reason='Bug 920700 - Sorting by Weekly Downloads produces incorrect sorting') | |||
There was a problem hiding this comment.
You are missing a blank line before this line, and there is also trailing space on this line.
|
Fixed |
|
LGTM. r+ Thanks @rushcreekdev! I will merge this after you squash your commits. |
|
Great job @rushcreekdev! Thanks for the awesome pull request. Merging. |
bobsilverberg
added a commit
that referenced
this pull request
Sep 25, 2013
made Xfail for bug 920700
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.