Key Movements #24

sgricci · 2012-03-28T14:15:17Z

Added ability to move around the map using arrow keys.

willurd · 2012-03-28T16:29:49Z

We might want to use WASD for right-handed players as this game also requires control of the mouse. Left handed players would probably still want to use the arrow keys:

case Types.Keys.LEFT:
case Types.Keys.A:
    game.makePlayerGoLeft();
    break;

sgricci · 2012-03-28T18:14:48Z

@willurd: thanks for the suggestion, I've added WASD and "space" for attack, as well as several other hotkeys for other parts of the interface

willurd · 2012-03-28T18:30:48Z

Nice!

… if you were hovering over a colliding tile

Keylan · 2012-03-28T19:45:35Z

Hotkeys still seem to be active while typing in chat box, which causes movement as well as help, achievement windows, etc. to open while typing a message. I'd suggest deactivating these hotkeys while the chat window is open. :-)

christosporios · 2012-03-28T19:50:32Z

This was really needed, nice.

joequery · 2012-03-28T21:05:33Z

@Keylan Would the best way to proceed with that be offer an entirely different switch statement based on

 if($('#chatbox').hasClass('active'))...

?

Keylan · 2012-03-28T21:22:34Z

@joequery I don't think an entirely different switch case is necessary. Can probably just edit the if statement before it to:
if (game.started && !$('#chatbox').hasClass('active')) {

considering the handler for the enter key is before the if statement.

joequery · 2012-03-28T21:36:38Z

@Keylan Ah, good point, I didn't realize that all the keys relate to out of chat functionality.

damajor · 2012-03-28T22:42:57Z

WASD does not suit any keyboards, think about other kb layouts.

willurd · 2012-03-28T22:47:53Z

@damajor Do you mean that it doesn't suit all keyboard layouts?

namanix · 2012-03-29T04:58:03Z

Ever heard of azerty keyboards. If not. Google it. And view the pictures. And look at the places of the keys. It will make you gasp ;p

willurd · 2012-03-29T05:08:54Z

@namanix I'm sure most programmers are aware that non-qwerty keyboard layouts exist. Short of providing some mechanism of configuring key bindings (which is possibly something we might want to look into), I'm unsure how we might go about supporting all of them.

damajor · 2012-03-29T06:49:00Z

@willurd : you cannot use WASD on some kb layouts because it has no meaning due to the keys location.

willurd · 2012-03-29T07:02:47Z

@damajor How would you get around that?

damajor · 2012-03-29T07:21:39Z

Honestly I didnt dig into JS features so I can only propose 2 ways to work around this issue:

let the user sets the keys he wants to use for Up/Left/Right/Down...

or

(far from being efficient) grab the main existing kb layouts and do some preconf inside the JS based on the kb layout detection (but I dont know if it is feasible).

christosporios · 2012-03-29T11:51:51Z

@damajor Yes, but why do that? Why complicate the UI by adding an additional menu with configuration options that 95% of the users will never touch? In this case, I think simplicity is more important than configurability. Whoever doesn't like the keyboard commands can just use their mouse. I think azerty keyboard users will actually be glad BrowserQuest provides mouse support.

damajor · 2012-03-29T12:20:49Z

@tech-no-crat Complicated UI, yes that is what we are debating here. I just think that when a feature is implemented it has to be done the right way and in a way to be portable and available for everyone.

Making a feature and saying to someone or a bunch of people "no you can't use it because you do not live there or there and/or does not own such kind of peripheral" is just too easy.

I wont argue on you arguments that says that azerty people should be happy to have their mouse to be able to play the game, I am just sick of that....

sgricci · 2012-03-29T12:23:48Z

You can also use arrow keys.

Also, you can always run your own server and change the keys setup in the
shared/js/gametypes.js file.
On Mar 29, 2012 8:20 AM, "Xav" <
reply@reply.github.com>
wrote:

@tech-no-crat Complicated UI, yes that is what we are debating here. I
just think that when a feature is implemented it has to be done the right
way and in a way to be portable and available for everyone.

Making a feature and saying to someone or a bunch of people "no you can't
use it because you do not live there or there and/or does not own such kind
of peripheral" is just too easy.

I wont argue on you arguments that says that azerty people should be happy
to have their mouse to be able to play the game, I am just sick of that....

Reply to this email directly or view it on GitHub:
#24 (comment)

christosporios · 2012-03-29T12:51:21Z

@damajor:

Complicated UI, yes that is what we are debating here

Configurability and simplicity do depend on each other.

I just think that when a feature is implemented it has to be done the right way and in a way to be portable and available for everyone. Making a feature and saying to someone or a bunch of people "no you can't use it because you do not live there or there and/or does not own such kind of peripheral" is just too easy.

Sadly, that's practically impossible. There are target groups for every feature. Mobile phones and tablets won't get this feature no matter what. Using a mobile device is their choice and so is using a specific keyboard. Non-QWERTY keyboards are very rare and the users who choose them are probably not using them for gaming anyway. And if they are, as @sgricci said, they can still use the arrows and the mouse. Don't forget that this feature is completely optional. Plus this is an open-source project, go ahead and fork it if you insist.

I like this pull request as it is. Anyway, this isn't really worth debating.

I wish I could resist:

sgricci · 2012-03-29T12:58:01Z

All I can say is I literally laughed out loud. I think that's the first
time someone has commented on a pull request I made with a meme.

Well done sir!
On Mar 29, 2012 8:51 AM, "Christos Porios" <
reply@reply.github.com>
wrote:

@damajor:

Complicated UI, yes that is what we are debating here

Configurability and simplicity do depend on each other.

I just think that when a feature is implemented it has to be done the
right way and in a way to be portable and available for everyone. Making a
feature and saying to someone or a bunch of people "no you can't use it
because you do not live there or there and/or does not own such kind of
peripheral" is just too easy.

Sadly, that's practically impossible. There are target groups for every
feature. Mobile phones and tablets won't get this feature no matter what.
Using a mobile device is their choice and so is using a specific keyboard.
Non-QWERTY keyboards are very rare and the users who choose them are
probably not using them for gaming anyway. And if they are, as @sgricci
said, they can still use the arrows and the mouse. Don't forget that this
feature is completely optional. Plus this is an open-source project, go
ahead and fork it if you insist.

I like this pull request as it is. Anyway, this isn't really worth
debating.

I wish I could resist:

Reply to this email directly or view it on GitHub:
#24 (comment)

sgricci · 2012-03-29T13:00:45Z

Also, @xav would it help if I added numpad support?
On Mar 29, 2012 8:57 AM, "Stephen Gricci" steve@gricci.org wrote:

All I can say is I literally laughed out loud. I think that's the first
time someone has commented on a pull request I made with a meme.

Well done sir!
On Mar 29, 2012 8:51 AM, "Christos Porios" <
reply@reply.github.com>
wrote:

@damajor:

Complicated UI, yes that is what we are debating here

Configurability and simplicity do depend on each other.

I just think that when a feature is implemented it has to be done the
right way and in a way to be portable and available for everyone. Making a
feature and saying to someone or a bunch of people "no you can't use it
because you do not live there or there and/or does not own such kind of
peripheral" is just too easy.

Sadly, that's practically impossible. There are target groups for every
feature. Mobile phones and tablets won't get this feature no matter what.
Using a mobile device is their choice and so is using a specific keyboard.
Non-QWERTY keyboards are very rare and the users who choose them are
probably not using them for gaming anyway. And if they are, as @sgricci
said, they can still use the arrows and the mouse. Don't forget that this
feature is completely optional. Plus this is an open-source project, go
ahead and fork it if you insist.

I like this pull request as it is. Anyway, this isn't really worth
debating.

I wish I could resist:

Reply to this email directly or view it on GitHub:
#24 (comment)

damajor · 2012-03-29T13:29:34Z

@sgricci : I already proposed some kind of workaround, you are of course free to decide which one (or none) to implement. Well anyway I wont participate to this issue anymore due to the exceptional level of unnecessary and not constructive remarks contained... BTW Good luck.

@tech-no-crat : I am really sad to say that but you seem to be a so short minded guy...

LiamDawe · 2012-03-30T18:58:40Z

As long as i can use WASD for movement i will be happy, keep up the good work!

jedahan · 2012-04-04T18:03:58Z

Incremental improvements. +1 for qwerty support, thanks for the patch!

sbstjn · 2012-04-10T20:54:31Z

thanks @sgricci, #78 is built upon your code…

justinclift · 2012-09-13T16:59:28Z

@sgricci Just committed your pull request to the repo here.

Trying to get all of the useful looking commits together in one spot, to make future development easier. :)

nickdesaulniers · 2013-09-03T23:43:37Z

Thanks for taking a look at the source code for BrowserQuest! BrowserQuest was developed by Little Workshop on behalf of Mozilla to showcase how the Web is the ultimate cross platform for games.

Mozilla does not currently have the resources to maintain BrowserQuest, but you should check out some of these amazing community forks instead! Feel free to add your fork to the wiki.

English

browserquest/browserquest - The general development group
- Running game here, you're welcome to join: http://browserquest-teambq.rhcloud.com:8000
ParticleQuest - Making particle physics fun. The goal of this project is to create a science based story modifying BrowserQuest.

Korean

Burger Burger Online: http://burgerburger.kr - Extremely well developed, significantly expanded from the original BrowserQuest
- Community: http://asky.freethinker.kr
- English is being added
- Older source: https://github.com/browserquest/BrowserQuest-Asky

Android

BrowserQuest for Android - BrowserQuest client, available in the Android store

Windows Phone

BrowserQuest for Windows Phone - BrowserQuest, in Windows Phone store

Erlang based

sedrik/bqs - Erlang implementation of the BrowserQuest server

C++ based

chain710/browserquestcc - C++ implementation of the BrowserQuest server

No longer actively developed

French

UFB World: http://ufbteam.com/fr
- Source: https://github.com/hackziner/ufbworld

sgricci added 2 commits March 28, 2012 10:01

Key Movements

3b9498e

Typo in 'goUp' logic

116f805

Added several more hot keys

ab7d496

sgricci added 4 commits March 28, 2012 14:35

Fixed an issue where moving by keys would cause screen not to switch

363e0e2

Walking in the direction of an NPC will act as if you clicked on them

338a30c

Removing swp files

d80230e

Fixed an issue which would cause you to not be able to move with keys…

02be838

… if you were hovering over a colliding tile

Added fux for chatbox + keyboard commands

d522e6f

Added support for keypad 2,4,6,8 as directional keys

8d58e13

nickdesaulniers closed this Sep 3, 2013

sbstjn mentioned this pull request Apr 10, 2012

Arduino Joystick Controller with WebSockets #78

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key Movements #24

Key Movements #24

sgricci commented Mar 28, 2012

willurd commented Mar 28, 2012

sgricci commented Mar 28, 2012

willurd commented Mar 28, 2012

Keylan commented Mar 28, 2012

christosporios commented Mar 28, 2012

joequery commented Mar 28, 2012

Keylan commented Mar 28, 2012

joequery commented Mar 28, 2012

damajor commented Mar 28, 2012

willurd commented Mar 28, 2012

namanix commented Mar 29, 2012

willurd commented Mar 29, 2012

damajor commented Mar 29, 2012

willurd commented Mar 29, 2012

damajor commented Mar 29, 2012

christosporios commented Mar 29, 2012

damajor commented Mar 29, 2012

sgricci commented Mar 29, 2012

christosporios commented Mar 29, 2012

sgricci commented Mar 29, 2012

sgricci commented Mar 29, 2012

damajor commented Mar 29, 2012

LiamDawe commented Mar 30, 2012

jedahan commented Apr 4, 2012

sbstjn commented Apr 10, 2012

justinclift commented Sep 13, 2012

nickdesaulniers commented Sep 3, 2013

Key Movements #24

Key Movements #24

Conversation

sgricci commented Mar 28, 2012

willurd commented Mar 28, 2012

sgricci commented Mar 28, 2012

willurd commented Mar 28, 2012

Keylan commented Mar 28, 2012

christosporios commented Mar 28, 2012

joequery commented Mar 28, 2012

Keylan commented Mar 28, 2012

joequery commented Mar 28, 2012

damajor commented Mar 28, 2012

willurd commented Mar 28, 2012

namanix commented Mar 29, 2012

willurd commented Mar 29, 2012

damajor commented Mar 29, 2012

willurd commented Mar 29, 2012

damajor commented Mar 29, 2012

christosporios commented Mar 29, 2012

damajor commented Mar 29, 2012

sgricci commented Mar 29, 2012

christosporios commented Mar 29, 2012

sgricci commented Mar 29, 2012

sgricci commented Mar 29, 2012

damajor commented Mar 29, 2012

LiamDawe commented Mar 30, 2012

jedahan commented Apr 4, 2012

sbstjn commented Apr 10, 2012

justinclift commented Sep 13, 2012

nickdesaulniers commented Sep 3, 2013

Related

No longer actively developed