Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 Linux wheel without ucs4 support #1276

Closed
fluffyGator opened this issue Feb 28, 2018 · 6 comments
Closed

Python 2.7 Linux wheel without ucs4 support #1276

fluffyGator opened this issue Feb 28, 2018 · 6 comments

Comments

@fluffyGator
Copy link

Could a Python 2.7, Linux wheel be supported that doesn't have the --enable-unicode=ucs4 (-cp27mu-) requirement. Most Python Linux installs aren't usually compiled with this flag (e.g. Canopy Python package) in my experience. The OSX 2.7 wheel works well with just the --enable-unicode=ucs2 flag, so I suspect it isn't critical.

@lissyx lissyx self-assigned this Feb 28, 2018
@lissyx lissyx added this to To do in Deep Speech v0.4.0 via automation Feb 28, 2018
@lissyx
Copy link
Collaborator

lissyx commented Feb 28, 2018

@dursch00 We are using pyenv for building this package, I don't know how we should change the unicode configure flag. I'll investigate closely, but this is likely to be the root cause of https://discourse.mozilla.org/t/unable-to-install-deepspeech-on-centos-6-9/26023

@lissyx
Copy link
Collaborator

lissyx commented Feb 28, 2018

Ok, that was faster than I expected, I found that on some github issue:

PYTHON_CONFIGURE_OPTS="--enable-unicode=ucs4" pyenv install

I'm wondering if there's value in more than cp27-m and cp27-mu variants ?

@lissyx
Copy link
Collaborator

lissyx commented Feb 28, 2018

@dursch00 This should be an easy task, mostly duplicating the current 2.7 builds and just tweaking do_deepspeech_python_build to add the configure flags. If you like, you can try a PR :)

@fluffyGator
Copy link
Author

Thanks for quick response.. One thing I just noticed that may adversely affect this that tensorflow also doesn't have a cp27m option for Linux ....

@lissyx
Copy link
Collaborator

lissyx commented Feb 28, 2018

I don't think it's such a big deal, there is still value for us in providing the deepspeech python bindings for those systems.

lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
lissyx pushed a commit to lissyx/STT that referenced this issue Mar 1, 2018
Deep Speech v0.4.0 automation moved this from To do to Done Mar 1, 2018
@lock
Copy link

lock bot commented Jan 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

2 participants