Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bin/run-ldc93s1.sh run faster #1952

Merged
merged 1 commit into from Mar 13, 2019
Merged

Make bin/run-ldc93s1.sh run faster #1952

merged 1 commit into from Mar 13, 2019

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Mar 13, 2019

The main use of bin/run-ldc93s1.sh is to test our code, not any training aspect, so I propose we make it faster to speed-up edit-test cycles. With these changes I can run it in 5 seconds on my laptop CPU, which is pretty good.

@lissyx
Copy link
Collaborator

lissyx commented Mar 13, 2019

Does it still overfit properly for producing a model we can use in the tests ?

@reuben
Copy link
Contributor Author

reuben commented Mar 13, 2019

I didn't change the scripts used by tests. But yes, it does.

@lissyx
Copy link
Collaborator

lissyx commented Mar 13, 2019

r=me++ then

@lissyx lissyx self-requested a review March 13, 2019 13:23
Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@reuben reuben merged commit 1a114c4 into master Mar 13, 2019
@reuben reuben deleted the faster-ldc93s1.sh branch March 13, 2019 14:00
@lock
Copy link

lock bot commented Apr 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants