Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TensorFlow v1.13 #1957

Merged
merged 2 commits into from Mar 19, 2019
Merged

Update to TensorFlow v1.13 #1957

merged 2 commits into from Mar 19, 2019

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Mar 14, 2019

No description provided.

@reuben
Copy link
Contributor Author

reuben commented Mar 14, 2019

Mostly green, just needs the Dockerfile to be updated and the Windows CUDA worker update to be deployed.

kdavis-mozilla
kdavis-mozilla approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lissyx
Copy link
Collaborator

lissyx commented Mar 15, 2019

@reuben CUDA v10.0 has been now properly redeployed, I've retriggered in https://tools.taskcluster.net/groups/B2QqIbPgQ7SBXl7GB4HTCA/tasks/K-4g1DZzTTO6O637PBOYpw/runs/0

lissyx
lissyx approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just make sure we forget no place where 1.13.1 is needed, and of course, green tests :)

requirements.txt Show resolved Hide resolved
@9define
Copy link

9define commented Mar 16, 2019

Is there a possibility to have this be updated to work with CUDA 10.1 that has been recently deployed? Thanks!

@lissyx
Copy link
Collaborator

lissyx commented Mar 16, 2019

@9define Upstream seems to recomment 10.0 for now

lissyx
lissyx reviewed Mar 16, 2019
View reviewed changes
taskcluster/.shared.yml Outdated Show resolved Hide resolved
@lissyx
Copy link
Collaborator

lissyx commented Mar 16, 2019

@9define Straight from the NVIDIA forums: https://devtalk.nvidia.com/default/topic/1047898/cuda-10-1-tensorflow-1-13
tl;dr "TensorFlow r1.13 breaks with CUDA 10.1"

@reuben reuben force-pushed the update-1.13 branch 5 times, most recently from 0c075c6 to b5fa2bb Compare March 19, 2019 10:35
@reuben reuben merged commit eadc9ec into master Mar 19, 2019
@reuben reuben deleted the update-1.13 branch March 19, 2019 23:06
@lock
Copy link

lock bot commented Apr 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lissyx lissyx lissyx approved these changes

@kdavis-mozilla kdavis-mozilla kdavis-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reuben @lissyx @9define @kdavis-mozilla