Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get past welcome with small screen #221

Closed
secretrobotron opened this issue Oct 1, 2016 · 4 comments
Closed

Can't get past welcome with small screen #221

secretrobotron opened this issue Oct 1, 2016 · 4 comments

Comments

@secretrobotron
Copy link
Contributor

The welcome screen is too long for phones with small screens. As a result, the "continue" button is hidden. However, this screen won't scroll. 😞

@ryanwarsaw
Copy link
Contributor

@secretrobotron You need to be a bit more descriptive, for example what phone were you testing on and what version of Android was it running? Was this a pre-existing bug or a brand new one?

@secretrobotron
Copy link
Contributor Author

Sorry, man. Was hard to grab that info. Was a small Huawei phone, but was
acting too quick to get more detail. Main observation: small and
rectangular.

Not sure if this was a pre-existing bug. Using the latest release from
mzl.la/jisort. If there is a new one i can mess around with, i will try.

Le 1 oct. 2016 23:50, "Ryan" notifications@github.com a écrit :

@secretrobotron https://github.com/secretrobotron You need to be a bit
more descriptive, for example what phone were you testing on and what
version of Android was it running? Was this a pre-existing bug or a brand
new one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#221 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAYnHxgedJc2DJZlDvVnI3yp-VNZfDbdks5qvseKgaJpZM4KLvu2
.

@ryanwarsaw
Copy link
Contributor

@secretrobotron Then yes, it was a pre-existing bug. Currently the builds at mzl.la/jisort are several versions old, I'm still working on the latest deployment implementation.

I'll see if I can get to this sometime next week, I'm not going to make any guarantees because I've got a few other bugs down the pipeline that also need fixing.

@ryanwarsaw
Copy link
Contributor

ryanwarsaw commented Oct 3, 2016

I was able to replicate this issue and identified the cause, looking to get a patch for it soon.

ryanwarsaw added a commit that referenced this issue Oct 5, 2016
Use layout weight to scale welcome image based on available screen space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants