remove old_topic (#1636)

* remove old_topic * adding test for change
mozilla · May 27, 2020 · 0fe049f · 0fe049f
1 parent 4998158
commit 0fe049f
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/mq/plugins/zoom_mapping.yml b/mq/plugins/zoom_mapping.yml
@@ -33,7 +33,6 @@ api_aws_lambda:
   original_sched_duration: details.payload.old_object.duration
   original_sched_duration: details.payload.old_object.id
   original_sched_start_time: details.payload.old_object.start_time
-  original_sched_topic: details.payload.old_object.topic
   username: details.payload.operator
   user_id: details.payload.operator_id
   ts: details.payload.time_stamp

diff --git a/tests/mq/plugins/test_zoom_fixup.py b/tests/mq/plugins/test_zoom_fixup.py
@@ -440,3 +440,52 @@ def test_recording_file_end_empty_string(self):
         }
         assert retmessage == expected_message
         assert retmeta == {}
+
+    def test_remove_old_topic_string(self):
+        msg = {
+            'summary': 'zoom_event',
+            'source': 'api_aws_lambda',
+            'hostname': 'zoom_host',
+            'severity': 'info',
+            'eventsource': 'MozDef-EF-zoom',
+            'tags': ['zoom', 'MozDef-EF-zoom-dev'],
+            'category': 'zoom',
+            'details': {
+                'event': 'meeting.updated',
+                'payload': {
+                    'account_id': 'ABCDEFG123456',
+                    'object': {
+                        'account_id': 'ABCDEFG123456',
+                        'id': '123456789',
+                        'type': '2',
+                        'uuid': 'aodij/OWIE9241048='
+                    },
+                    'old_object': {
+                        'topic': 'my secret meeting',
+                        'duration': '60'
+                    }
+                }
+            }
+        }
+        (retmessage, retmeta) = self.plugin.onMessage(msg, {})
+
+        expected_message = {
+            'summary': 'zoom: meeting.updated',
+            'category': 'zoom',
+            'source': 'api_aws_lambda',
+            'hostname': 'zoom_host',
+            'severity': 'info',
+            'eventsource': 'MozDef-EF-zoom',
+            'tags': ['zoom', 'MozDef-EF-zoom-dev'],
+            'processname': 'zoom_webhook_api',
+            'details': {
+                'account_id': 'ABCDEFG123456',
+                'event': 'meeting.updated',
+                'id': '123456789',
+                'type': '2',
+                'uuid': 'aodij/OWIE9241048=',
+                'original_sched_duration': '60'
+            }
+        }
+        assert retmessage == expected_message
+        assert retmeta == {}