Fix tests.

pollbot/tasks/__init__.py

@@ -30,8 +30,8 @@ def build_task_response(status, link, message, fail_message=None):
     if isinstance(status, bool):
         if not fail_message:
             fail_message = message
-        status = Status.EXISTS if status else Status.MISSING
         message = message if status else fail_message
+        status = Status.EXISTS if status else Status.MISSING
 
     return {
         "status": status.value,

pollbot/tasks/product_details.py

@@ -39,8 +39,9 @@ async def product_details(product, version):
 
             exists_message = "We found product-details information about version {}".format(
                 version)
-            missing_message = "We did not found product-details information about version".format(
-                version)
+            missing_message = (
+                "We did not found product-details information about version {}".format(
+                    version))
             return build_task_response(status, url, exists_message, missing_message)
 
 

tests/test_tasks.py

@@ -465,13 +465,16 @@ async def test_product_details_tasks_returns_true_if_present(self):
 
         received = await product_details('firefox', '52.0')
         assert received["status"] == Status.EXISTS.value
+        assert received["message"] == "We found product-details information about version 52.0"
 
     async def test_product_details_tasks_returns_false_if_absent(self):
         url = 'https://product-details.mozilla.org/1.0/firefox.json'
         self.mocked.get(url, status=200, body=json.dumps({"releases": {"firefox-52.0": {}}}))
 
         received = await product_details('firefox', '54.0')
         assert received["status"] == Status.MISSING.value
+        assert received["message"] == (
+            "We did not found product-details information about version 54.0")
 
     async def test_product_details_tasks_returns_error_if_error(self):
         url = 'https://product-details.mozilla.org/1.0/firefox.json'