Add a test for buildhub checks.

mozilla · Oct 30, 2017 · af9d6f9 · af9d6f9
1 parent 701d0af
commit af9d6f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pollbot/tasks/buildhub.py b/pollbot/tasks/buildhub.py
@@ -60,6 +60,9 @@ async def get_build_ids_for_version(product, version, *, size=10):
 
 
 async def buildhub(product, version):
+    if 'build' in version:
+        version = version.replace('build', 'rc')
+
     try:
         build_ids = await get_build_ids_for_version(product, version)
         status = True

diff --git a/tests/test_views.py b/tests/test_views.py
@@ -458,6 +458,15 @@ async def test_candidates_buildhub(cli):
                             "?versions[0]=56.0.1rc2&products[0]=firefox&channel[0]=release")
 
 
+async def test_candidates_buildhub_build(cli):
+    resp = await check_response(cli, "/v1/firefox/56.0.1build2/buildhub")
+    body = await resp.json()
+    assert body["status"] == Status.EXISTS.value
+    assert "Build IDs for this release: 20171002220106" == body["message"]
+    assert body["link"] == ("https://mozilla-services.github.io/buildhub/"
+                            "?versions[0]=56.0.1rc2&products[0]=firefox&channel[0]=release")
+
+
 async def test_release_bedrock_release_notes(cli):
     await check_response(cli, "/v1/firefox/54.0/bedrock/release-notes", body={
         "status": Status.EXISTS.value,