Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Channel AURORA for devedition. #177

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Use Channel AURORA for devedition. #177

merged 1 commit into from
Jan 29, 2018

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Jan 29, 2018

Fixes #176

@Natim Natim requested a review from magopian January 29, 2018 09:54
@Natim Natim added this to Blocked in Version 1.0 Jan 29, 2018
Copy link
Contributor

@magopian magopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)

Does this mean we'll need to change "devedition" to "aurora" for the "channel" on the delivery-dashboard?

@sylvestre
Copy link
Contributor

please don't use aurora in the frontend. aurora as a product is dead. Only devedition

@Natim
Copy link
Contributor Author

Natim commented Jan 29, 2018

please don't use aurora in the frontend. aurora as a product is dead. Only devedition

It is not Aurora as a product but aurora as a channel

@magopian
Copy link
Contributor

@Natim is there a (simple) way to still use "beta" in pollbot instead of "aurora"? Otherwise i'll "translate" it in the delivery-dashboard.

@Natim
Copy link
Contributor Author

Natim commented Jan 29, 2018

is there a (simple) way to still use "beta" in pollbot instead of "aurora"

I guess if that's what you want we shouldn't merge this PR. But that's not what I understand from @sylvestre comment. He is talking about the Aurora product, with this work we still use devedition. That's just the channel. If I understand correctly the channel for devedition is aurora and not beta but please tell me I am wrong if it is the case.

@magopian
Copy link
Contributor

I believe @sylvestre's comment is only cosmetic: whatever the real channel name is, it should be displayed as devedition.

@Natim Natim merged commit e9220f0 into master Jan 29, 2018
Version 1.0 automation moved this from Blocked to Completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.0
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants