Compare uptake with previous version. #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
force-pushed
the
171-telemetry-uptake
branch
from
b1641e4
to
7604e2a
Compare
leplatrem
reviewed
Jan 29, 2018
| version = [r["key"] for r in build_id_bucket["versions"]["buckets"] | ||
| if strip_candidate_info(r['key']) == r['key']] | ||
| if version: | ||
| versions.append((version_build_id, version[0])) |
There was a problem hiding this comment.
This looks very obscure to fresh eyes :(
Could you please add some comments? Mainly why do we aggregate by buildid (and not by version anymore) and why we have to strip_candidate_info() etc.
Natim
changed the title
Natim
force-pushed
the
171-telemetry-uptake
branch
from
7604e2a
to
05ec210
Compare
added 2 commits
January 30, 2018 15:56
Natim
changed the title
|
Maybe this information is irrelevant and I will close it as wontfix in favor of #172 |
This was referenced Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171