fix(content): #632 Bug 1269777 - Google search string from context me…

…nu wrongly searches
mozilla · May 24, 2016 · 02f5f70 · 02f5f70
1 parent d19be4d
commit 02f5f70
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/content-src/components/SiteIcon/SiteIcon.js b/content-src/components/SiteIcon/SiteIcon.js
@@ -34,7 +34,7 @@ const SiteIcon = React.createClass({
       <div ref="border" hidden={!showBackground || !showBorder} className="inner-border" />
       <div className="site-icon-wrapper">
         <img ref="favicon" width={faviconSize} height={faviconSize} className="site-icon-favicon" hidden={showFallback} src={site.favicon} />
-        <span ref="fallback" className="site-icon-fallback" style={fallbackStyle} hidden={!showFallback}>{site.firstLetter}</span>
+        <span ref="fallback" className="site-icon-fallback" style={fallbackStyle} hidden={!showFallback} data-first-letter={site.firstLetter} />
       </div>
       <div ref="title" hidden={!showTitle} className="site-icon-title">{site.label}</div>
     </div>);

diff --git a/content-src/components/SiteIcon/SiteIcon.scss b/content-src/components/SiteIcon/SiteIcon.scss
@@ -27,6 +27,10 @@
   .site-icon-fallback {
     text-transform: uppercase;
     opacity: 0.75;
+
+    &::after {
+      content: attr(data-first-letter);
+    }
   }
 
   .site-icon-title {

diff --git a/content-test/components/SiteIcon.test.js b/content-test/components/SiteIcon.test.js
@@ -97,7 +97,10 @@ describe("SiteIcon", () => {
       assert.equal(instance.refs.background.style.backgroundColor, "rgb(0, 0, 0)");
     });
     it("should use the first letter of the host name", () => {
-      assert.equal(instance.refs.fallback.innerHTML, "f");
+      assert.equal(instance.refs.fallback.dataset.firstLetter, "f");
+    });
+    it("should not affect the content text", () => {
+      assert.equal(instance.refs.fallback.innerHTML, "");
     });
   });
 });