Merge pull request #563 from k88hudson/gh555

fix(addon): #555 Add search to cache key
mozilla · Apr 25, 2016 · 5b99c82 · 5b99c82
2 parents 61b8a89 + 86a38a3
commit 5b99c82
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/PreviewProvider.js b/lib/PreviewProvider.js
@@ -151,7 +151,7 @@ PreviewProvider.prototype = {
   _createCacheKey(url) {
     url = new URL(url);
     let key = url.host.replace(/www\.?/, "");
-    key = key + url.pathname;
+    key = key + url.pathname + (url.search || "");
     return key.toString();
   },
 

diff --git a/test/test-PreviewProvider.js b/test/test-PreviewProvider.js
@@ -250,6 +250,7 @@ exports.test_dedupe_urls = function*(assert) {
   let expectedUrls = [
     {"url": "http://foo.com/", "title": "blah"},
     {"url": "http://foo.com/bar/foobar", "title": "blah"},
+    {"url": "https://www.foo.com/?q=param", "title": "blah"},
     {"url": "http://localhost-foo.com", "title": "blah"}
   ];