Fix Bug 1483257 - update search shortcuts when enabling experiment (#…

…4341)
mozilla · Aug 14, 2018 · b2d7f56 · b2d7f56
1 parent f7f1e45
commit b2d7f56
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/TopSitesFeed.jsm b/lib/TopSitesFeed.jsm
@@ -648,7 +648,9 @@ this.TopSitesFeed = class TopSitesFeed {
             this.refresh({broadcast: true});
             break;
           case SEARCH_SHORTCUTS_EXPERIMENT:
-            if (!action.data.value) {
+            if (action.data.value) {
+              this.updateCustomSearchShortcuts();
+            } else {
               this.disableSearchImprovements();
             }
             this.refresh({broadcast: true});

diff --git a/test/unit/lib/TopSitesFeed.test.js b/test/unit/lib/TopSitesFeed.test.js
@@ -1236,6 +1236,16 @@ describe("Top Sites Feed", () => {
       assert.deepEqual(fakeNewTabUtils.pinnedLinks.links[3], {url: "https://dontunpinme.com"});
     });
 
+    it("should updateCustomSearchShortcuts when experiment pref is turned on", async () => {
+      feed.store.state.Prefs.values[SEARCH_SHORTCUTS_EXPERIMENT_PREF] = false;
+      feed.updateCustomSearchShortcuts = sinon.spy();
+
+      // turn the experiment on
+      feed.onAction({type: at.PREF_CHANGED, data: {name: SEARCH_SHORTCUTS_EXPERIMENT_PREF, value: true}});
+
+      assert.calledOnce(feed.updateCustomSearchShortcuts);
+    });
+
     it("should filter out default top sites that match a hostname of a search shortcut if previously blocked", async () => {
       feed.refreshDefaults("https://amazon.ca");
       fakeNewTabUtils.blockedLinks.links = [{url: "https://amazon.com"}];