Rename to

mozilla · Jul 8, 2019 · b5253f1 · b5253f1
1 parent b795b25
commit b5253f1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/content-src/asrouter/docs/targeting-attributes.md b/content-src/asrouter/docs/targeting-attributes.md
@@ -35,7 +35,7 @@ Please note that some targeting attributes require stricter controls on the tele
 * [xpinstallEnabled](#xpinstallEnabled)
 * [hasPinnedTabs](#haspinnedtabs)
 * [hasAccessedFxAPanel](#hasaccessedfxapanel)
-* [hasWhatsNewPanelEnabled](#haswhatsnewpanelenabled)
+* [isWhatsNewPanelEnabled](#iswhatsnewpanelenabled)
 
 ## Detailed usage
 
@@ -487,12 +487,12 @@ Boolean pref that gets set the first time the user opens the FxA toolbar panel
 declare const hasAccessedFxAPanel: boolean;
 ```
 
-### `hasWhatsNewPanelEnabled`
+### `isWhatsNewPanelEnabled`
 
 Boolean pref that controls if the What's New panel feature is enabled
 
 #### Definition
 
 ```ts
-declare const hasWhatsNewPanelEnabled: boolean;
+declare const isWhatsNewPanelEnabled: boolean;
 ```
diff --git a/lib/ASRouterTargeting.jsm b/lib/ASRouterTargeting.jsm
@@ -394,7 +394,7 @@ const TargetingGetters = {
       true
     );
   },
-  get hasWhatsNewPanelEnabled() {
+  get isWhatsNewPanelEnabled() {
     return Services.prefs.getBoolPref(
       "browser.messaging-system.whatsNewPanel.enabled",
       false

diff --git a/lib/OnboardingMessageProvider.jsm b/lib/OnboardingMessageProvider.jsm
@@ -491,7 +491,7 @@ const ONBOARDING_MESSAGES = async () => [
       lifetime: Infinity,
     },
     // Never saw this message or saw it in the past 4 days or more recent
-    targeting: `hasWhatsNewPanelEnabled &&
+    targeting: `isWhatsNewPanelEnabled &&
       (firefoxVersion > previousSessionFirefoxVersion &&
         messageImpressions[.id == 'WHATS_NEW_BADGE_${FIREFOX_VERSION}']|length == 0) ||
       (messageImpressions[.id == 'WHATS_NEW_BADGE_${FIREFOX_VERSION}']|length >= 1 &&

diff --git a/test/browser/browser_asrouter_targeting.js b/test/browser/browser_asrouter_targeting.js
@@ -823,17 +823,17 @@ add_task(async function check_hasAccessedFxAPanel() {
   );
 });
 
-add_task(async function check_hasWhatsNewPanelEnabled() {
+add_task(async function check_isWhatsNewPanelEnabled() {
   is(
-    await ASRouterTargeting.Environment.hasWhatsNewPanelEnabled,
+    await ASRouterTargeting.Environment.isWhatsNewPanelEnabled,
     false,
     "Not enabled yet"
   );
 
   await pushPrefs(["browser.messaging-system.whatsNewPanel.enabled", true]);
 
   is(
-    await ASRouterTargeting.Environment.hasWhatsNewPanelEnabled,
+    await ASRouterTargeting.Environment.isWhatsNewPanelEnabled,
     true,
     "Should update based on pref"
   );