Fix Bug 1515663 - Block FxA snippet on form submit (#4635)

mozilla · Jan 7, 2019 · c56b04a · c56b04a
1 parent 06fbd77
commit c56b04a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/content-src/asrouter/templates/SubmitFormSnippet/SubmitFormSnippet.jsx b/content-src/asrouter/templates/SubmitFormSnippet/SubmitFormSnippet.jsx
@@ -38,6 +38,7 @@ export class SubmitFormSnippet extends React.PureComponent {
     this.props.sendUserActionTelemetry({event: "CLICK_BUTTON", value: "conversion-subscribe-activation", id: "NEWTAB_FOOTER_BAR_CONTENT"});
 
     if (this.props.form_method.toUpperCase() === "GET") {
+      this.props.onBlock({preventDismiss: true});
       this.refs.form.submit();
       return;
     }

diff --git a/test/unit/asrouter/templates/SubmitFormSnippet.test.jsx b/test/unit/asrouter/templates/SubmitFormSnippet.test.jsx
@@ -249,5 +249,14 @@ describe("SubmitFormSnippet", () => {
 
       assert.notCalled(window.fetch);
     });
+    it("should block the snippet when form_method is GET", () => {
+      wrapper.setProps({form_method: "GET"});
+      wrapper.setState({expanded: true});
+
+      wrapper.instance().handleSubmit({preventDefault: sandbox.stub()});
+
+      assert.calledOnce(onBlockStub);
+      assert.calledWithExactly(onBlockStub, {preventDismiss: true});
+    });
   });
 });