fix(preferences): Use plain DOM instead of XBL appendItem (#4042)

Followup to bug 1404890
mozilla · Mar 15, 2018 · dc6b52e · dc6b52e
1 parent a69232d
commit dc6b52e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/system-addon/lib/AboutPreferences.jsm b/system-addon/lib/AboutPreferences.jsm
@@ -204,9 +204,12 @@ this.AboutPreferences = class AboutPreferences {
 
           // Add appropriate number of localized entries to the dropdown
           const menulist = createAppend("menulist", detailHbox);
+          const menupopup = createAppend("menupopup", menulist);
           for (let num = 1; num <= maxRows; num++) {
             const plurals = formatString({id: "prefs_section_rows_option", values: {num}});
-            menulist.appendItem(PluralForm.get(num, plurals), num);
+            const item = createAppend("menuitem", menupopup);
+            item.setAttribute("label", PluralForm.get(num, plurals));
+            item.setAttribute("value", num);
           }
           linkPref(menulist, rowsPref, "int");
         }

diff --git a/system-addon/test/unit/lib/AboutPreferences.test.js b/system-addon/test/unit/lib/AboutPreferences.test.js
@@ -133,7 +133,6 @@ describe("AboutPreferences Feed", () => {
     beforeEach(() => {
       node = {
         appendChild: sandbox.stub().returnsArg(0),
-        appendItem: sandbox.stub(),
         classList: {add: sandbox.stub()},
         cloneNode: sandbox.stub().returnsThis(),
         insertAdjacentElement: sandbox.stub().returnsArg(1),
@@ -238,7 +237,9 @@ describe("AboutPreferences Feed", () => {
 
         testRender();
 
-        assert.calledThrice(node.appendItem);
+        assert.calledWith(node.setAttribute, "value", 1);
+        assert.calledWith(node.setAttribute, "value", 2);
+        assert.calledWith(node.setAttribute, "value", 3);
       });
     });
     describe("nested prefs", () => {