Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

The Top Sites context menu button is misalligned #1547

Closed
SoftVision-CiprianMuresan opened this issue Oct 13, 2016 · 5 comments
Closed

The Top Sites context menu button is misalligned #1547

SoftVision-CiprianMuresan opened this issue Oct 13, 2016 · 5 comments
Assignees
Labels

Comments

@SoftVision-CiprianMuresan

[Affected versions]:

  • Firefox 45.0 and up
  • Activity Stream 1.1.4-dev

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Latest Activity Stream add-on version (1.1.4-dev) was previously installed on a clean profile.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and open a new tab.
  2. Hover any of the Top Sites tiles and observe the Context Menu button position.

[Expected result]:

  • The Context Menu button appears in the upper right corner of the tile.

[Actual result]:

  • The Context Menu button appears over its normal position.

[Additional Notes]:

  • The issue is not reproducible for Highlights tiles.
  • Attached a screenshot of the issue.
    top sites context menu is misalligned
@rlr rlr self-assigned this Oct 17, 2016
@rlr
Copy link
Contributor

rlr commented Oct 18, 2016

I'm not seeing this issue at all on the 1.5 pre-release build.

With an existing profile:
screen shot 2016-10-18 at 4 45 51 pm

With a brand new profile:
screen shot 2016-10-18 at 4 47 46 pm

And running the master branch on nightly is good too:
screen shot 2016-10-18 at 4 48 49 pm

Closing for now. Please re-open if you are still seeing the issue.

In the screenshot it appears that something was actually pushing the Top Sites tiles down and the context menu button is where it's supposed to be. But I'm not sure what may have caused that and I can't repro.

@rlr rlr closed this as completed Oct 18, 2016
@SoftVision-CiprianMuresan
Copy link
Author

I can still reproduce this on the latest Nightly (Build ID 20161018030211) regardless of where I install AS from, so something changed in the browser which caused this "regression". Aurora and Beta are not affected (yet).

I did a regression range and got the following pushlog.
Looks like the following bug has the changes which introduced the regression:
Bug 1306894

@rlr
Copy link
Contributor

rlr commented Oct 19, 2016

@SoftVision-CiprianMuresan ah, I didn't have the latest nightly. Now I can repro. Thanks!

rlr added a commit to rlr/activity-streams that referenced this issue Oct 19, 2016
@rlr
Copy link
Contributor

rlr commented Oct 19, 2016

^ fixed. @ncloudioj will cherry pick onto the release

@SoftVision-CiprianMuresan
Copy link
Author

The issue is no longer reproducible on the latest version (1.1.5).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants